[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #942: feat(e2e): add e2e test for prometheus

[GitBox <gi...@apache.org>]

Chever-John commented on code in PR #942:
URL: https://github.com/apache/apisix-ingress-controller/pull/942#discussion_r842101895


##########
test/e2e/plugins/server-info.go:
##########
@@ -32,7 +32,7 @@ var _ = ginkgo.Describe("server-info plugin", func() {
 	}
 	s := scaffold.NewScaffold(opts)
 
-	ginkgo.It("enable server-info plugin", func() {
+	ginkgo.It("enable server-info plugin_", func() {

Review Comment:
   @tao12345666333 
   I have run into an unexpected problem.
   I just have modified the e2e test file for "global_rule". 
   But it transferred the CI error reporting to the "server-info" plugin's e2e test file.
   
   I have just tried as follows.
   1. reinstall docker containers after run 
   `sudo docker rm $(docker ps -a -q)` and 
   `sudo rmi $(docker images -a)` and 
   `sudo docker volume prune`.
   2. and `git reset` to the version that we did not change the apisix-alpine(version is reseted to 2.12). There still be problem. 
   3. The error message is `expect is True, actual is false`. (Sry, forgive me have delete all data and do not copy the former error message.
   
   I am looking forward to hear from you!



##########
test/e2e/features/global_rule.go:
##########
@@ -42,7 +42,13 @@ metadata:
   name: default
 spec:
   monitoring:
-    prometheus:
+  - name: rule1
+	plugins:
+  	- name: public-api
+	  enable: true
+	  config:
+		  uri: /apisix/prometheus/metrics

Review Comment:
   Got it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org