You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/06/19 00:11:00 UTC
[PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
dongjoon-hyun opened a new pull request, #56605:
URL: https://github.com/apache/spark/pull/56605
### What changes were proposed in this pull request?
This PR aims to make `docker-image-tool.sh` and K8s IT `README.md` up-to-date for Apache Spark 4.0.0.
### Why are the changes needed?
To provide an up-to-date information for Spark 5.
### Does this PR introduce _any_ user-facing change?
No behavior change except the usage message and test documentation.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on code in PR #56605:
URL: https://github.com/apache/spark/pull/56605#discussion_r3439622762
##########
bin/docker-image-tool.sh:
##########
@@ -261,18 +261,18 @@ Examples:
$0 -m -t testing build
- Build PySpark docker image
- $0 -r docker.io/myrepo -t v4.0.0 -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
+ $0 -r docker.io/myrepo -t v5.0.0 -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
- - Build and push image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push image with tag "v5.0.0" to docker.io/myrepo
+ $0 -r docker.io/myrepo -t v5.0.0 build
+ $0 -r docker.io/myrepo -t v5.0.0 push
- - Build and push Java17-based image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 -b java_image_tag=17 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push Java17-based image with tag "v5.0.0" to docker.io/myrepo
Review Comment:
nit: The description says "Java17-based" but the example uses java_image_tag=21. Should the description be updated to "Java21-based"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56605:
URL: https://github.com/apache/spark/pull/56605#issuecomment-4747170273
Could you review this PR, @sarutak ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56605:
URL: https://github.com/apache/spark/pull/56605#issuecomment-4747258688
Thank you so much, @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #56605: [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date
URL: https://github.com/apache/spark/pull/56605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #56605:
URL: https://github.com/apache/spark/pull/56605#discussion_r3439629320
##########
bin/docker-image-tool.sh:
##########
@@ -261,18 +261,18 @@ Examples:
$0 -m -t testing build
- Build PySpark docker image
- $0 -r docker.io/myrepo -t v4.0.0 -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
+ $0 -r docker.io/myrepo -t v5.0.0 -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
- - Build and push image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push image with tag "v5.0.0" to docker.io/myrepo
+ $0 -r docker.io/myrepo -t v5.0.0 build
+ $0 -r docker.io/myrepo -t v5.0.0 push
- - Build and push Java17-based image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 -b java_image_tag=17 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push Java17-based image with tag "v5.0.0" to docker.io/myrepo
Review Comment:
Oh, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #56605:
URL: https://github.com/apache/spark/pull/56605#discussion_r3439632715
##########
bin/docker-image-tool.sh:
##########
@@ -261,18 +261,18 @@ Examples:
$0 -m -t testing build
- Build PySpark docker image
- $0 -r docker.io/myrepo -t v4.0.0 -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
+ $0 -r docker.io/myrepo -t v5.0.0 -p kubernetes/dockerfiles/spark/bindings/python/Dockerfile build
- - Build and push image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push image with tag "v5.0.0" to docker.io/myrepo
+ $0 -r docker.io/myrepo -t v5.0.0 build
+ $0 -r docker.io/myrepo -t v5.0.0 push
- - Build and push Java17-based image with tag "v4.0.0" to docker.io/myrepo
- $0 -r docker.io/myrepo -t v4.0.0 -b java_image_tag=17 build
- $0 -r docker.io/myrepo -t v4.0.0 push
+ - Build and push Java17-based image with tag "v5.0.0" to docker.io/myrepo
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57545][K8S] Make `docker-image-tool.sh` and K8s IT readme up-to-date [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #56605:
URL: https://github.com/apache/spark/pull/56605#issuecomment-4747291702
Since this is a document-only change, the CI result is irrelevant. I'm going to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org