You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "baeminbo (via GitHub)" <gi...@apache.org> on 2024/10/22 03:18:51 UTC

[PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

baeminbo opened a new pull request, #32893:
URL: https://github.com/apache/beam/pull/32893

   Fix #32892.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2433866540

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2430688004

   r: @scwhittle
   
   I assign you as the reviewer since this is with Windmill appliance.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2428431587

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @chamikaramj added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2428422637

   assign set of reviewers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on code in PR #32893:
URL: https://github.com/apache/beam/pull/32893#discussion_r1812859876


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillMap.java:
##########
@@ -142,6 +142,7 @@ protected Windmill.WorkItemCommitRequest persistDirectly(WindmillStateCache.ForK
           .setTag(keyBytes)
           .setStateFamily(stateFamily)
           .getValueBuilder()

Review Comment:
   Thanks. I fixed it to remove the code from `getValueBuilder()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2430636489

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2430684079

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle merged PR #32893:
URL: https://github.com/apache/beam/pull/32893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2430688989

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2428326705

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "baeminbo (via GitHub)" <gi...@apache.org>.
baeminbo commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2434136580

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on code in PR #32893:
URL: https://github.com/apache/beam/pull/32893#discussion_r1812272640


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillMap.java:
##########
@@ -142,6 +142,7 @@ protected Windmill.WorkItemCommitRequest persistDirectly(WindmillStateCache.ForK
           .setTag(keyBytes)
           .setStateFamily(stateFamily)
           .getValueBuilder()

Review Comment:
   nit: I think you can fix instead by removing the valuebuilder and settimestamp and it's simpler code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix protobuf build error in WindmillMap.persistDirect() for a removal in Dataflow Streaming Java Legacy Runner without Streaming Engine [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32893:
URL: https://github.com/apache/beam/pull/32893#issuecomment-2428185602

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org