You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "enjoy-binbin (via GitHub)" <gi...@apache.org> on 2023/09/01 13:42:15 UTC
[GitHub] [kvrocks] enjoy-binbin opened a new pull request, #1723: Add MOVE command as Redis
enjoy-binbin opened a new pull request, #1723:
URL: https://github.com/apache/kvrocks/pull/1723
Since kvrocks don't support Redis DBs, so this is a dummy command.
If key does not exist, the command returns 0, otherwise it will always
returns 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] torwig commented on a diff in pull request #1723: Add MOVE command as Redis
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on code in PR #1723:
URL: https://github.com/apache/kvrocks/pull/1723#discussion_r1313117103
##########
tests/gocase/unit/introspection/introspection_test.go:
##########
@@ -203,6 +203,18 @@ func TestIntrospection(t *testing.T) {
require.NoError(t, rdb.Set(ctx, "a", "b", 0).Err())
require.GreaterOrEqual(t, time.Since(now).Seconds(), 2.0)
})
+
+ t.Run("MOVE dummy coverage", func(t *testing.T) {
+ require.Error(t, rdb.Do(ctx, "MOVE", "key", "dbid").Err())
+
+ // key dose not exist, return 0
Review Comment:
A tiny typo here: `dose` => `does`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] enjoy-binbin commented on a diff in pull request #1723: Add MOVE command as Redis
Posted by "enjoy-binbin (via GitHub)" <gi...@apache.org>.
enjoy-binbin commented on code in PR #1723:
URL: https://github.com/apache/kvrocks/pull/1723#discussion_r1313153125
##########
tests/gocase/unit/introspection/introspection_test.go:
##########
@@ -203,6 +203,18 @@ func TestIntrospection(t *testing.T) {
require.NoError(t, rdb.Set(ctx, "a", "b", 0).Err())
require.GreaterOrEqual(t, time.Since(now).Seconds(), 2.0)
})
+
+ t.Run("MOVE dummy coverage", func(t *testing.T) {
+ require.Error(t, rdb.Do(ctx, "MOVE", "key", "dbid").Err())
+
+ // key dose not exist, return 0
Review Comment:
```suggestion
// key does not exist, return 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] enjoy-binbin merged pull request #1723: Add MOVE command as Redis
Posted by "enjoy-binbin (via GitHub)" <gi...@apache.org>.
enjoy-binbin merged PR #1723:
URL: https://github.com/apache/kvrocks/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org