[GitHub] [spark] Ngone51 commented on a diff in pull request #38668: [SPARK-41153][CORE] Log migrated shuffle data size and migration time

[GitBox <gi...@apache.org>]

Ngone51 commented on code in PR #38668:
URL: https://github.com/apache/spark/pull/38668#discussion_r1035963605


##########
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala:
##########
@@ -125,7 +126,10 @@ private[storage] class BlockManagerDecommissioner(
                   logDebug(s"Migrated sub-block $blockId")
                 }
               }
-              logInfo(s"Migrated $shuffleBlockInfo to $peer")
+              lazy val endTime = System.currentTimeMillis()
+              lazy val totalBlockSize = Utils.bytesToString(blocks.map(b => b._2.size()).sum)
+              logInfo(s"Migrated $shuffleBlockInfo (" +
+                s"size: $totalBlockSize) to $peer in ${endTime - startTime} ms")

Review Comment:
   How about
   ```suggestion
                 logInfo(s"Migrated $shuffleBlockInfo (" +
                   s"size: ${Utils.bytesToString(blocks.map(b => b._2.size()).sum)}) to $peer in ${System.currentTimeMillis() - startTime} ms")
   ```
   to avoid those two lazy variables?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org