You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/12 12:41:00 UTC

[jira] [Commented] (AVRO-1966) NPE When copying builder with nullable record

    [ https://issues.apache.org/jira/browse/AVRO-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287537#comment-16287537 ] 

ASF GitHub Bot commented on AVRO-1966:
--------------------------------------

GitHub user nielsbasjes opened a pull request:

    https://github.com/apache/avro/pull/264

    Backporting two NPE fixes from master to branch-1.8

    I cherry-picked the commits for AVRO-1966 and AVRO-1967 which are both fixes for NPE situations that I would really like to be part of the next 1.8.x release.
    
    I only had conflicts in the CHANGES.txt and the build ran fine on my machine.
    
    Please double check if I did it correctly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nielsbasjes/avro AVRO-1966-1.8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
    
----
commit 50d63a1bf1ee7cfa11303cc9d2b7ae5d8c707265
Author: Niels Basjes <ni...@apache.org>
Date:   2016-11-30T20:50:13Z

    AVRO-1966: Java: Fix NPE When copying builder with nullable record.

commit 4ed487786bb75732d8d86f7cd4be39f7a615b705
Author: Niels Basjes <nb...@bol.com>
Date:   2016-12-01T12:44:57Z

    AVRO-1967: Java: Fix NPE when calling getXyzBuilder on instance where the xyz is null

----


> NPE When copying builder with nullable record
> ---------------------------------------------
>
>                 Key: AVRO-1966
>                 URL: https://issues.apache.org/jira/browse/AVRO-1966
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>            Priority: Critical
>             Fix For: 1.8.2
>
>
> Assume a schema with a record that embeds a record that is optional (i.e. the reference is union with null) and has the default value null.
> Then create a builder and copy that builder into a new builder.
> Using this copy will yield a NulPointerException. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)