You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/07/19 10:27:49 UTC
Review Request 50188: LENS-1218: Document the new ui in install and
run step
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218
Repository: lens
Description
-------
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java b82cd95b5633b91e03cf1df8ac2602cb7798099a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java d10ad099b7220545802a3fcc7fd6e32a1c5b272a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d5f16b3fc7fffff6c5cfa78c6b9a694c1d
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 803bbe3db982dc74ba2a1bdba94fc68879dcd351
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239
src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
Diff: https://reviews.apache.org/r/50188/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/#review143062
-----------------------------------------------------------
src/site/apt/lenshome/install-and-run.apt (line 246)
<https://reviews.apache.org/r/50188/#comment208766>
Seems incomplete here. Can you remove it from here ?
- Amareshwari Sriramadasu
On July 21, 2016, 7:20 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50188/
> -----------------------------------------------------------
>
> (Updated July 21, 2016, 7:20 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1218
> https://issues.apache.org/jira/browse/LENS-1218
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> src/site/apt/developer/contribute.apt a2fd59eacbef1bd63eaf59f7d744893e495a6056
> src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
>
> Diff: https://reviews.apache.org/r/50188/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
-----------------------------------------------------------
(Updated July 21, 2016, 7 p.m.)
Review request for lens.
Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218
Repository: lens
Description
-------
Diffs (updated)
-----
src/site/apt/developer/contribute.apt a2fd59eacbef1bd63eaf59f7d744893e495a6056
src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
Diff: https://reviews.apache.org/r/50188/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/#review143065
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On July 21, 2016, 8:45 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50188/
> -----------------------------------------------------------
>
> (Updated July 21, 2016, 8:45 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1218
> https://issues.apache.org/jira/browse/LENS-1218
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> src/site/apt/developer/contribute.apt a2fd59eacbef1bd63eaf59f7d744893e495a6056
> src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
>
> Diff: https://reviews.apache.org/r/50188/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
-----------------------------------------------------------
(Updated July 21, 2016, 2:15 p.m.)
Review request for lens.
Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218
Repository: lens
Description
-------
Diffs (updated)
-----
src/site/apt/developer/contribute.apt a2fd59eacbef1bd63eaf59f7d744893e495a6056
src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
Diff: https://reviews.apache.org/r/50188/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
-----------------------------------------------------------
(Updated July 21, 2016, 12:50 p.m.)
Review request for lens.
Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218
Repository: lens
Description
-------
Diffs (updated)
-----
src/site/apt/developer/contribute.apt a2fd59eacbef1bd63eaf59f7d744893e495a6056
src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
Diff: https://reviews.apache.org/r/50188/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/#review142724
-----------------------------------------------------------
src/site/apt/lenshome/install-and-run.apt (line 237)
<https://reviews.apache.org/r/50188/#comment208365>
Should there commands be run inside ui/ folder ? If so, seems user has to do extra npm install
- Amareshwari Sriramadasu
On July 19, 2016, 10:35 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50188/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 10:35 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1218
> https://issues.apache.org/jira/browse/LENS-1218
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
>
> Diff: https://reviews.apache.org/r/50188/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/#review142725
-----------------------------------------------------------
src/site/apt/lenshome/install-and-run.apt (line 241)
<https://reviews.apache.org/r/50188/#comment208366>
Lets us update build from source doc in contributor guide to use node_modules from lens-ui module directly.
- Amareshwari Sriramadasu
On July 19, 2016, 10:35 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50188/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 10:35 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1218
> https://issues.apache.org/jira/browse/LENS-1218
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
>
> Diff: https://reviews.apache.org/r/50188/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50188: LENS-1218: Document the new ui in install
and run step
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50188/
-----------------------------------------------------------
(Updated July 19, 2016, 4:05 p.m.)
Review request for lens.
Bugs: LENS-1218
https://issues.apache.org/jira/browse/LENS-1218
Repository: lens
Description
-------
Diffs (updated)
-----
src/site/apt/lenshome/install-and-run.apt f13382263d88edae9ec78f59f3476910ff650453
Diff: https://reviews.apache.org/r/50188/diff/
Testing
-------
Thanks,
Rajat Khandelwal