You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/12 01:05:21 UTC

[GitHub] [kafka] kowshik commented on pull request #10489: MINOR Moved tiered storage API classes from clients module to a new storage-api module.

kowshik commented on pull request #10489:
URL: https://github.com/apache/kafka/pull/10489#issuecomment-817414476


   I just looked at the clients code under `kafka/clients/`. As an example to @ijuma's suggestion, I see the interface: `org.apache.kafka.common.KafkaFuture` and its implementation in: `org.apache.kafka.common.internals.KafkaFutureImpl`. This type of separation looks good too.
   
   @ijuma Does the existing approach in this PR have any disadvantages, or the suggestion to use `.internals` has more to do with being consistent with how we do it in clients already? I read the article linked above, but I wasn't sure if it'd apply to us here, but I could be wrong.
   
   cc @satishd @junrao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org