You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2013/05/06 22:30:45 UTC
[Android] Can rename DroidGap to CordovaActivity?
Hey
I think it's a secret to no one that I despise the DroidGap class and
that I would like to see it refactored into non-existance. However,
given the fact that we don't have the time for that right now, can we
at least rename it to CordovaActivity and create an empty DroidGap
class derived from it for backwards compatibility reasons?
Do we think that this is doable by the time 3.0 is out?
Joe
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Gorkem Ercan <go...@gmail.com>.
Should this also update the TAG value for logs?
https://github.com/apache/cordova-android/pull/52
--
Gorkem
http://www.gorkem-ercan.com
On Tue, May 7, 2013 at 12:54 PM, Joe Bowser <bo...@gmail.com> wrote:
> Done! I've committed it so that when we pull things in they should go
> to the right place. I'm hoping we can avoid pull-request breakage
> this way, but who knows.
>
>
> On Mon, May 6, 2013 at 8:14 PM, Ally Ogilvie <ao...@wizcorp.jp> wrote:
> > +1 CordovaActivity.
> >
> >
> > On Tue, May 7, 2013 at 9:19 AM, Simon MacDonald
> > <si...@gmail.com>wrote:
> >
> >> SGTM2
> >>
> >> Simon Mac Donald
> >> http://hi.im/simonmacdonald
> >>
> >>
> >> On Mon, May 6, 2013 at 4:30 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>
> >> > Hey
> >> >
> >> > I think it's a secret to no one that I despise the DroidGap class and
> >> > that I would like to see it refactored into non-existance. However,
> >> > given the fact that we don't have the time for that right now, can we
> >> > at least rename it to CordovaActivity and create an empty DroidGap
> >> > class derived from it for backwards compatibility reasons?
> >> >
> >> > Do we think that this is doable by the time 3.0 is out?
> >> >
> >> > Joe
> >> >
> >>
> >
> >
> >
> > --
> > <http://www.wizcorp.jp/>Ally Ogilvie
> > Lead Developer - MobDev. | Wizcorp Inc. <http://www.wizcorp.jp/>
> > ------------------------------
> > TECH . GAMING . OPEN-SOURCE WIZARDS+ 81 (0)3-4550-1448 |
> > Website<http://www.wizcorp.jp/>
> > | Twitter <https://twitter.com/Wizcorp> |
> > Facebook<http://www.facebook.com/Wizcorp>
> > | LinkedIn <http://www.linkedin.com/company/wizcorp>
>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Joe Bowser <bo...@gmail.com>.
Done! I've committed it so that when we pull things in they should go
to the right place. I'm hoping we can avoid pull-request breakage
this way, but who knows.
On Mon, May 6, 2013 at 8:14 PM, Ally Ogilvie <ao...@wizcorp.jp> wrote:
> +1 CordovaActivity.
>
>
> On Tue, May 7, 2013 at 9:19 AM, Simon MacDonald
> <si...@gmail.com>wrote:
>
>> SGTM2
>>
>> Simon Mac Donald
>> http://hi.im/simonmacdonald
>>
>>
>> On Mon, May 6, 2013 at 4:30 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>> > Hey
>> >
>> > I think it's a secret to no one that I despise the DroidGap class and
>> > that I would like to see it refactored into non-existance. However,
>> > given the fact that we don't have the time for that right now, can we
>> > at least rename it to CordovaActivity and create an empty DroidGap
>> > class derived from it for backwards compatibility reasons?
>> >
>> > Do we think that this is doable by the time 3.0 is out?
>> >
>> > Joe
>> >
>>
>
>
>
> --
> <http://www.wizcorp.jp/>Ally Ogilvie
> Lead Developer - MobDev. | Wizcorp Inc. <http://www.wizcorp.jp/>
> ------------------------------
> TECH . GAMING . OPEN-SOURCE WIZARDS+ 81 (0)3-4550-1448 |
> Website<http://www.wizcorp.jp/>
> | Twitter <https://twitter.com/Wizcorp> |
> Facebook<http://www.facebook.com/Wizcorp>
> | LinkedIn <http://www.linkedin.com/company/wizcorp>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Ally Ogilvie <ao...@wizcorp.jp>.
+1 CordovaActivity.
On Tue, May 7, 2013 at 9:19 AM, Simon MacDonald
<si...@gmail.com>wrote:
> SGTM2
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Mon, May 6, 2013 at 4:30 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> > Hey
> >
> > I think it's a secret to no one that I despise the DroidGap class and
> > that I would like to see it refactored into non-existance. However,
> > given the fact that we don't have the time for that right now, can we
> > at least rename it to CordovaActivity and create an empty DroidGap
> > class derived from it for backwards compatibility reasons?
> >
> > Do we think that this is doable by the time 3.0 is out?
> >
> > Joe
> >
>
--
<http://www.wizcorp.jp/>Ally Ogilvie
Lead Developer - MobDev. | Wizcorp Inc. <http://www.wizcorp.jp/>
------------------------------
TECH . GAMING . OPEN-SOURCE WIZARDS+ 81 (0)3-4550-1448 |
Website<http://www.wizcorp.jp/>
| Twitter <https://twitter.com/Wizcorp> |
Facebook<http://www.facebook.com/Wizcorp>
| LinkedIn <http://www.linkedin.com/company/wizcorp>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Simon MacDonald <si...@gmail.com>.
SGTM2
Simon Mac Donald
http://hi.im/simonmacdonald
On Mon, May 6, 2013 at 4:30 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I think it's a secret to no one that I despise the DroidGap class and
> that I would like to see it refactored into non-existance. However,
> given the fact that we don't have the time for that right now, can we
> at least rename it to CordovaActivity and create an empty DroidGap
> class derived from it for backwards compatibility reasons?
>
> Do we think that this is doable by the time 3.0 is out?
>
> Joe
>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Joe Bowser <bo...@gmail.com>.
The JIRA issue already exists: https://issues.apache.org/jira/browse/CB-2657
I believe that the 3.0 branch already had this, so I want to throw
this in 2.8 so we don't lose any improvements to DroidGap that we may
be making.
That being said, this doesn't fix the issue of it being a kitchen sink
as much as making people feel bad about putting so much crap in an
activity when they should know better. :P
On Mon, May 6, 2013 at 1:38 PM, Shazron <sh...@gmail.com> wrote:
> Pull request plus jira issue then ? ;)
>
>
> On Mon, May 6, 2013 at 1:35 PM, Lorin Beer <lo...@gmail.com> wrote:
>
>> I've been listening to you complain about the DroidGap class name for years
>> now, and will fully support you in the refactor.
>> I'll even plus one this on the rename
>>
>> but I have a question to ask:
>>
>> 1. does this add complexity for no other reason than to satisfy a
>> programmer itch?
>>
>>
>> On Mon, May 6, 2013 at 1:30 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>> > Hey
>> >
>> > I think it's a secret to no one that I despise the DroidGap class and
>> > that I would like to see it refactored into non-existance. However,
>> > given the fact that we don't have the time for that right now, can we
>> > at least rename it to CordovaActivity and create an empty DroidGap
>> > class derived from it for backwards compatibility reasons?
>> >
>> > Do we think that this is doable by the time 3.0 is out?
>> >
>> > Joe
>> >
>>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Shazron <sh...@gmail.com>.
Pull request plus jira issue then ? ;)
On Mon, May 6, 2013 at 1:35 PM, Lorin Beer <lo...@gmail.com> wrote:
> I've been listening to you complain about the DroidGap class name for years
> now, and will fully support you in the refactor.
> I'll even plus one this on the rename
>
> but I have a question to ask:
>
> 1. does this add complexity for no other reason than to satisfy a
> programmer itch?
>
>
> On Mon, May 6, 2013 at 1:30 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> > Hey
> >
> > I think it's a secret to no one that I despise the DroidGap class and
> > that I would like to see it refactored into non-existance. However,
> > given the fact that we don't have the time for that right now, can we
> > at least rename it to CordovaActivity and create an empty DroidGap
> > class derived from it for backwards compatibility reasons?
> >
> > Do we think that this is doable by the time 3.0 is out?
> >
> > Joe
> >
>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Lorin Beer <lo...@gmail.com>.
I've been listening to you complain about the DroidGap class name for years
now, and will fully support you in the refactor.
I'll even plus one this on the rename
but I have a question to ask:
1. does this add complexity for no other reason than to satisfy a
programmer itch?
On Mon, May 6, 2013 at 1:30 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I think it's a secret to no one that I despise the DroidGap class and
> that I would like to see it refactored into non-existance. However,
> given the fact that we don't have the time for that right now, can we
> at least rename it to CordovaActivity and create an empty DroidGap
> class derived from it for backwards compatibility reasons?
>
> Do we think that this is doable by the time 3.0 is out?
>
> Joe
>
Re: [Android] Can rename DroidGap to CordovaActivity?
Posted by Andrew Grieve <ag...@chromium.org>.
SGTM
On Mon, May 6, 2013 at 4:30 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> I think it's a secret to no one that I despise the DroidGap class and
> that I would like to see it refactored into non-existance. However,
> given the fact that we don't have the time for that right now, can we
> at least rename it to CordovaActivity and create an empty DroidGap
> class derived from it for backwards compatibility reasons?
>
> Do we think that this is doable by the time 3.0 is out?
>
> Joe
>