You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/06/14 16:08:47 UTC

[GitHub] [accumulo] keith-turner commented on a change in pull request #1206: Fix #1181 Update MasterMetadataUtil to use new Ample api

keith-turner commented on a change in pull request #1206: Fix #1181 Update MasterMetadataUtil to use new Ample api
URL: https://github.com/apache/accumulo/pull/1206#discussion_r293869723
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java
 ##########
 @@ -95,6 +95,21 @@ protected TabletMutatorBase(ServerContext ctx, KeyExtent extent) {
     return this;
   }
 
+  @Override
+  public Ample.TabletMutator putFlushId(long flushId) {
+    Preconditions.checkState(updatesEnabled, "Cannot make updates after calling mutate.");
+    TabletsSection.ServerColumnFamily.FLUSH_COLUMN.put(mutation,
+        new Value(("" + flushId).getBytes()));
 
 Review comment:
   Should use the Value constuctor that takes String and encodes with UTF8

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services