You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celix.apache.org by pn...@apache.org on 2021/05/07 07:10:10 UTC
[celix] branch hotfix/do_not_set_cxx_std created (now 9caa3b3)
This is an automated email from the ASF dual-hosted git repository.
pnoltes pushed a change to branch hotfix/do_not_set_cxx_std
in repository https://gitbox.apache.org/repos/asf/celix.git.
at 9caa3b3 Removes setting std=c++17 compiler option as INTERFACE on the promises lib.
This branch includes the following new commits:
new f4e7a12 Trying update to ubuntu 20.04 (from 18.04), because of dependency install issues.
new 9caa3b3 Removes setting std=c++17 compiler option as INTERFACE on the promises lib.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[celix] 02/02: Removes setting std=c++17 compiler option as
INTERFACE on the promises lib.
Posted by pn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pnoltes pushed a commit to branch hotfix/do_not_set_cxx_std
in repository https://gitbox.apache.org/repos/asf/celix.git
commit 9caa3b31ce7c5930031c7ce094e2eb7fde3ad255
Author: Pepijn Noltes <pe...@gmail.com>
AuthorDate: Fri May 7 09:07:06 2021 +0200
Removes setting std=c++17 compiler option as INTERFACE on the promises lib.
---
libs/promises/CMakeLists.txt | 2 +-
libs/promises/gtest/CMakeLists.txt | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/libs/promises/CMakeLists.txt b/libs/promises/CMakeLists.txt
index 61342f8..5c212f9 100644
--- a/libs/promises/CMakeLists.txt
+++ b/libs/promises/CMakeLists.txt
@@ -46,10 +46,10 @@ if (PROMISES OR PROMISES_STANDALONE)
$<INSTALL_INTERFACE:include/celix/promises>
)
target_link_libraries(Promises INTERFACE Threads::Threads)
- target_compile_options(Promises INTERFACE -std=c++17)
add_library(Celix::Promises ALIAS Promises)
add_executable(PromiseExamples src/PromiseExamples.cc)
+ target_compile_options(PromiseExamples PRIVATE -std=c++17)
target_link_libraries(PromiseExamples PRIVATE Celix::Promises)
if (ENABLE_TESTING AND NOT PROMISE_STANDALONE)
diff --git a/libs/promises/gtest/CMakeLists.txt b/libs/promises/gtest/CMakeLists.txt
index 209e40d..38cfa8d 100644
--- a/libs/promises/gtest/CMakeLists.txt
+++ b/libs/promises/gtest/CMakeLists.txt
@@ -20,6 +20,7 @@ add_executable(test_celix_promises
src/PromisesTestSuite.cc
src/VoidPromisesTestSuite.cc
)
+target_compile_options(test_celix_promises PRIVATE -std=c++17)
target_link_libraries(test_celix_promises PRIVATE GTest::gtest GTest::gtest_main Celix::Promises)
add_test(NAME test_celix_promises COMMAND test_celix_promises)
[celix] 01/02: Trying update to ubuntu 20.04 (from 18.04),
because of dependency install issues.
Posted by pn...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
pnoltes pushed a commit to branch hotfix/do_not_set_cxx_std
in repository https://gitbox.apache.org/repos/asf/celix.git
commit f4e7a129f99d7839ee8cf9554a6695420582127e
Author: Pepijn Noltes <pe...@gmail.com>
AuthorDate: Thu May 6 17:06:13 2021 +0200
Trying update to ubuntu 20.04 (from 18.04), because of dependency install issues.
---
.github/workflows/celix_etcdlib.yml | 2 +-
.github/workflows/celix_promise.yml | 2 +-
.github/workflows/coverage.yml | 2 +-
.github/workflows/coverity-scan.yml | 2 +-
.github/workflows/ubuntu-nightly.yml | 6 +++---
.github/workflows/ubuntu.yml | 6 +++---
6 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/.github/workflows/celix_etcdlib.yml b/.github/workflows/celix_etcdlib.yml
index ab0e2a5..10e6fbe 100644
--- a/.github/workflows/celix_etcdlib.yml
+++ b/.github/workflows/celix_etcdlib.yml
@@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- os: [ubuntu-18.04]
+ os: [ubuntu-20.04]
compiler: [gcc]
timeout-minutes: 15
steps:
diff --git a/.github/workflows/celix_promise.yml b/.github/workflows/celix_promise.yml
index 20e3de6..6e563da 100644
--- a/.github/workflows/celix_promise.yml
+++ b/.github/workflows/celix_promise.yml
@@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- os: [ubuntu-18.04]
+ os: [ubuntu-20.04]
compiler: [gcc]
timeout-minutes: 15
steps:
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index 84318d8..c0c19c0 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -4,7 +4,7 @@ on: [push, pull_request]
jobs:
coverage:
- runs-on: ubuntu-18.04
+ runs-on: ubuntu-20.04
steps:
- name: Checkout source code
uses: actions/checkout@v2
diff --git a/.github/workflows/coverity-scan.yml b/.github/workflows/coverity-scan.yml
index 109ace2..f1ba2e1 100644
--- a/.github/workflows/coverity-scan.yml
+++ b/.github/workflows/coverity-scan.yml
@@ -5,7 +5,7 @@ on:
jobs:
latest:
- runs-on: ubuntu-18.04
+ runs-on: ubuntu-20.04
steps:
- name: Checkout source code
uses: actions/checkout@v2
diff --git a/.github/workflows/ubuntu-nightly.yml b/.github/workflows/ubuntu-nightly.yml
index 709d111..94e22ad 100644
--- a/.github/workflows/ubuntu-nightly.yml
+++ b/.github/workflows/ubuntu-nightly.yml
@@ -13,17 +13,17 @@ jobs:
#os: [ubuntu-18.04, ubuntu-16.04]
#compiler: [gcc, clang]
include:
- - os: ubuntu-18.04
+ - os: ubuntu-20.04
name: clang
sanitizer: false #note sanitizer on clang with cpputest does not work
compiler: clang
cxx_compiler: clang++
- - os: ubuntu-18.04
+ - os: ubuntu-20.04
name: gcc
sanitizer: true
compiler: gcc
cxx_compiler: g++
- - os: ubuntu-18.04
+ - os: ubuntu-20.04
name: only v3 api
sanitizer: true
compiler: gcc
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
index 3ace04c..7a4f054 100644
--- a/.github/workflows/ubuntu.yml
+++ b/.github/workflows/ubuntu.yml
@@ -11,17 +11,17 @@ jobs:
#os: [ubuntu-18.04, ubuntu-16.04]
#compiler: [gcc, clang]
include:
- - os: ubuntu-18.04
+ - os: ubuntu-20.04
name: clang
sanitizer: false #note sanitizer on clang with cpputest does not work
compiler: clang
cxx_compiler: clang++
- - os: ubuntu-18.04
+ - os: ubuntu-20.04
name: gcc
sanitizer: true
compiler: gcc
cxx_compiler: g++
- - os: ubuntu-18.04
+ - os: ubuntu-20.04
name: only v3 api
sanitizer: true
compiler: gcc