You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/21 00:33:58 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4199: Update to arrow and parquet 27.0.0

liukun4515 commented on code in PR #4199:
URL: https://github.com/apache/arrow-datafusion/pull/4199#discussion_r1027384467


##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -572,7 +572,7 @@ mod tests {
                 Some(15000),
                 Some(25000),
                 Some(30000),
-                Some(11234),

Review Comment:
   > I believe this is caused by [apache/arrow-rs#3021](https://github.com/apache/arrow-rs/pull/3021) (cc @liukun4515 ) where now arrow will round 1.123_456_8 to the nearest integer rather than simply truncating it
   
   this changes is reasonable for me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org