You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Derek Huang (Code Review)" <ge...@cloudera.org> on 2024/12/19 02:26:44 UTC

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Derek Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22239


Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................

[tools] Run range aware cluster rebalance with multiple tables

Previously when rebalancing cluster with kudu command line tool, the
`--enable_range_rebalancing` flag requires the `--tables` flag with exactly one
table specified.

This commit removes this restriction, allowing multiple tables to be passed to
the `--tables` flag when range rebalancing is enabled. Among them, range
partitioned tables will be rebalanced with ranges considered, while others are
rebalanced as usual. If the `--tables` flag is not set, all tables in the
cluster will be rebalanced.

This commit also optimizes the replica distribution details when range
rabalancing is applied to multiple tables with mixed partition schemas.

Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
---
M src/kudu/rebalance/cluster_status.h
M src/kudu/rebalance/rebalance-test.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 132 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/22239/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 1
Gerrit-Owner: Derek Huang <xf...@gmail.com>

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Derek Huang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22239

to look at the new patch set (#2).

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................

[tools] Run range aware cluster rebalance with multiple tables

Previously when rebalancing cluster with kudu command line tool, the
`--enable_range_rebalancing` flag requires the `--tables` flag with exactly one
table specified.

This commit removes this restriction, allowing multiple tables to be passed to
the `--tables` flag when range rebalancing is enabled. Among them, range
partitioned tables will be rebalanced with ranges considered, while others are
rebalanced as usual. If the `--tables` flag is not set, all tables in the
cluster will be rebalanced.

This commit also optimizes the replica distribution details when range
rabalancing is applied to multiple tables with mixed partition schemas.

Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
---
M src/kudu/rebalance/cluster_status.h
M src/kudu/rebalance/rebalance-test.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 133 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/22239/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/857/


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 1
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 02:26:53 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 5:

> (1 comment)
 > 
 > > (1 comment)
 > >
 > > Thank you for the patch!
 > >
 > > Overall it looks good to me, just a tiny nit in the newly added
 > > test.
 > >
 > > BTW, did you try to run the updated `kudu cluster rebalance` tool
 > > against a real cluster?
 > 
 > I have tested the updated cluster rebalance tool on a real cluster
 > running a modified version of Kudu (based on Kudu 1.15,
 > cherry-picked commits relevant to range rebalancing). And it worked
 > :)

That's great news: thanks for verifying!


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Dec 2024 05:00:07 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................

[tools] Run range aware cluster rebalance with multiple tables

Previously when rebalancing cluster with kudu command line tool, the
`--enable_range_rebalancing` flag requires the `--tables` flag with exactly one
table specified.

This commit removes this restriction, allowing multiple tables to be passed to
the `--tables` flag when range rebalancing is enabled. Among them, range
partitioned tables will be rebalanced with ranges considered, while others are
rebalanced as usual. If the `--tables` flag is not set, all tables in the
cluster will be rebalanced.

This commit also optimizes the replica distribution details when range
rabalancing is applied to multiple tables with mixed partition schemas.

Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Reviewed-on: http://gerrit.cloudera.org:8080/22239
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rebalance/cluster_status.h
M src/kudu/rebalance/rebalance-test.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 133 insertions(+), 21 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 6
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 4: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/865/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 16:58:17 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/858/


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 02:43:38 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/857/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 1
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 02:35:30 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Derek Huang (Code Review)" <ge...@cloudera.org>.
Derek Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 5:

(1 comment)

> (1 comment)
 > 
 > Thank you for the patch!
 > 
 > Overall it looks good to me, just a tiny nit in the newly added
 > test.
 > 
 > BTW, did you try to run the updated `kudu cluster rebalance` tool
 > against a real cluster?

I have tested the updated cluster rebalance tool on a real cluster running a modified version of Kudu (based on Kudu 1.15, cherry-picked commits relevant to range rebalancing). And it worked :)

http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc
File src/kudu/tools/rebalancer_tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc@2407
PS4, Line 2407: ASSERT_EQ(1, table_names.size())
> nit for here and below: consider making the expected/reference to be the fi
fixed



-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 22 Dec 2024 17:38:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/860/


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 3
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 06:46:39 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/865/


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 15:51:51 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 5: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/877/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 22 Dec 2024 19:18:44 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/858/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 04:20:22 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Derek Huang (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22239

to look at the new patch set (#5).

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................

[tools] Run range aware cluster rebalance with multiple tables

Previously when rebalancing cluster with kudu command line tool, the
`--enable_range_rebalancing` flag requires the `--tables` flag with exactly one
table specified.

This commit removes this restriction, allowing multiple tables to be passed to
the `--tables` flag when range rebalancing is enabled. Among them, range
partitioned tables will be rebalanced with ranges considered, while others are
rebalanced as usual. If the `--tables` flag is not set, all tables in the
cluster will be rebalanced.

This commit also optimizes the replica distribution details when range
rabalancing is applied to multiple tables with mixed partition schemas.

Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
---
M src/kudu/rebalance/cluster_status.h
M src/kudu/rebalance/rebalance-test.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 133 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/22239/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/877/


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 22 Dec 2024 17:27:26 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 5: Code-Review+2

Thank you for the contribution!


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Dec 2024 04:59:23 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

Thank you for the patch!

Overall it looks good to me, just a tiny nit in the newly added test.

BTW, did you try to run the updated `kudu cluster rebalance` tool against a real cluster?

http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc
File src/kudu/tools/rebalancer_tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc@2407
PS4, Line 2407: ASSERT_EQ(table_names.size(), 1)
nit for here and below: consider making the expected/reference to be the first argument of the ASSERT_EQ() macro -- if this assertion ever triggers, it will be easier to read the error message



-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 21 Dec 2024 02:21:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tools] Run range aware cluster rebalance with multiple tables

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )

Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/860/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22239
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22239
Gerrit-PatchSet: 3
Gerrit-Owner: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2024 07:59:32 +0000
Gerrit-HasComments: No