You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2024/08/12 15:22:09 UTC

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21661


Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................

KUDU-3543: Add JSON Content-Type Header

This patch introduces path handlers for pages that require the
Content-Type header application/json and integrates them accordingly.
Additionally, the test data has been updated to ensure proper coverage.

Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/tracing_path_handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/test_util.cc
M src/kudu/util/web_callback_registry.h
7 files changed, 52 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/21661/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/444/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 21:52:10 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/426/


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 10:54:43 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 2:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/425/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 10:54:38 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................

KUDU-3543: Add JSON Content-Type Header

This patch introduces path handlers for pages that require the
Content-Type header application/json and integrates them accordingly.
Additionally, the test data has been updated to ensure proper coverage.

Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Reviewed-on: http://gerrit.cloudera.org:8080/21661
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/master_path_handlers.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/tracing_path_handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/jwt-util-test.cc
M src/kudu/util/mini_oidc.cc
M src/kudu/util/test_util.cc
M src/kudu/util/web_callback_registry.h
10 files changed, 62 insertions(+), 35 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/426/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 12:32:11 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 4: Verified+1

unrelated tests Java test failures (known flakies): org.apache.kudu.spark.kudu.DefaultSourceTest and org.apache.kudu.client.TestSecurity


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 23:09:10 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21661

to look at the new patch set (#2).

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................

KUDU-3543: Add JSON Content-Type Header

This patch introduces path handlers for pages that require the
Content-Type header application/json and integrates them accordingly.
Additionally, the test data has been updated to ensure proper coverage.

Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
---
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/tracing_path_handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/jwt-util-test.cc
M src/kudu/util/mini_oidc.cc
M src/kudu/util/test_util.cc
M src/kudu/util/web_callback_registry.h
9 files changed, 59 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/21661/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21661/1//COMMIT_MSG
Commit Message:

PS1: 
There are a few more handlers that de-facto output application/json pages:
  * /jwks.json, /jwks/$account_id, /.well-known/openid-configuration in src/kudu/util/mini-oidc.cc
  * /dump-entities in src/kudu/master/master_path_handlers.cc

Do you think it makes sense to updated those as well as a part of this changelist?


http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc@751
PS1, Line 751:     case StyleMode::UNSTYLED:
             :       content_type = "text/plain";
Since this is going to apply to any page (even for the newly marked as JSON in this patch) when supplying 'raw' parameter in the URL of the HTTP request, maybe at some point it makes sense to revisit the registration of other endpoints and probably separate the original semantics of the StyleMode enum (i.e. whether to feed through mustache template or not) and the newly added content-type semantics.

It's better to do so in a separate changelist, I guess.



-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2024 23:45:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/425/


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 10:40:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/405/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2024 16:16:54 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/444/


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 20:48:22 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21661/1//COMMIT_MSG
Commit Message:

PS1: 
> There are a few more handlers that de-facto output application/json pages:
Thanks for double checking the endpoints, good catch! Added those mentioned. MiniOidc is in my understantind test infrastructure therefore opted not to write explicit tests to check the content-type header values on those endpoints. The Json handler’s functionality is basically validated in the master&tserver tests. However if you feel like we should add content-type header tests to MiniOidc, I can follow up.


http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc@751
PS1, Line 751:     case StyleMode::UNSTYLED:
             :       content_type = "text/plain";
> Since this is going to apply to any page (even for the newly marked as JSON
Yepp this is valid. Created a jira to track this improvement: KUDU-3609. Thanks for bringing this to my attention!



-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 10:56:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/405/


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 12 Aug 2024 15:22:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 23:09:14 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 1:

Unrelated test failure: 
Release: org.apache.kudu.spark.kudu.DefaultSourceTest


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2024 16:27:20 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2024 16:27:35 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3543: Add JSON Content-Type Header

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21661

to look at the new patch set (#3).

Change subject: KUDU-3543: Add JSON Content-Type Header
......................................................................

KUDU-3543: Add JSON Content-Type Header

This patch introduces path handlers for pages that require the
Content-Type header application/json and integrates them accordingly.
Additionally, the test data has been updated to ensure proper coverage.

Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
---
M src/kudu/master/master_path_handlers.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/tracing_path_handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/jwt-util-test.cc
M src/kudu/util/mini_oidc.cc
M src/kudu/util/test_util.cc
M src/kudu/util/web_callback_registry.h
10 files changed, 62 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/21661/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829
Gerrit-Change-Number: 21661
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>