You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axkit-dev@xml.apache.org by ma...@apache.org on 2003/08/05 01:05:17 UTC
cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
mach 2003/08/04 16:05:17
Modified: lib/Apache/AxKit ConfigReader.pm
Log:
Fixing styles leaking into #global style cache. (subsequent
requests would see styles from previous requests).
Revision Changes Path
1.18 +6 -2 xml-axkit/lib/Apache/AxKit/ConfigReader.pm
Index: ConfigReader.pm
===================================================================
RCS file: /home/cvs/xml-axkit/lib/Apache/AxKit/ConfigReader.pm,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- ConfigReader.pm 11 Jul 2003 16:03:54 -0000 1.17
+++ ConfigReader.pm 4 Aug 2003 23:05:17 -0000 1.18
@@ -384,7 +384,11 @@
$style ||= '#default';
# Add global styles
- my $list = $self->{cfg}{Processors}{$media}{'#global'} || [];
+ my $list = [];
+
+ if( exists($self->{cfg}{Processors}{$media}{'#global'})) {
+ push @$list, @{ $self->{cfg}{Processors}{$media}{'#global'} || []};
+ }
# Add styles matching this style
if (exists($self->{cfg}{Processors}{$media}{$style})) {
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Michael Chamberlain <mi...@btinternet.com>.
>
> (I've tested all 3 locally, but someone else might want to check,
> since my xslt-basic tests
> don't all pass on all those builds - current investigating).
>
xslt-basic/01........................................ok
xslt-basic/02_include................................ok
xslt-basic/03_document_1arg..........................ok
xslt-basic/04_document_2args.........................ok
Woo :) Broken catalog support in libxml, rebuilt it with
--without-catalog, commented out
two lines in LibXML which broke when this option is disabled, and it
all works ;)
No idea why it was broke to start with though.
Mike.
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Jörg Walter <em...@hab.ich.garni.ch>.
Am Thursday, 07. August 2003 00:47, schrieb Matt Sergeant:
> On Wednesday, Aug 6, 2003, at 21:03 Europe/London, Michael Chamberlain
>
> wrote:
> > OK new tests commited.
> >
> > New tests should pass in cvs.
> > Fail against 1.6.2
> > Pass against 1.6.1
>
> Confirmed here. New test system rocks (Kip++!).
>
> Anything else we want to get into a quick update (I'm expecting Moe to
> shout real soon with a new large UTF8 patch :-)
No, there's just the yet uncommitted
attribs-with-namespaces-in-xsp-lose-their-namespace bugfix. I will commit it
today.
--
CU
Joerg
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Matt Sergeant <ma...@sergeant.org>.
On Wednesday, Aug 6, 2003, at 21:03 Europe/London, Michael Chamberlain
wrote:
> OK new tests commited.
>
> New tests should pass in cvs.
> Fail against 1.6.2
> Pass against 1.6.1
Confirmed here. New test system rocks (Kip++!).
Anything else we want to get into a quick update (I'm expecting Moe to
shout real soon with a new large UTF8 patch :-)
Matt.
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Michael Chamberlain <mi...@btinternet.com>.
OK new tests commited.
New tests should pass in cvs.
Fail against 1.6.2
Pass against 1.6.1
(I've tested all 3 locally, but someone else might want to check, since
my xslt-basic tests
don't all pass on all those builds - current investigating).
Mike.
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Michael Chamberlain <mi...@btinternet.com>.
On Wednesday, August 6, 2003, at 01:03 am, Matt Sergeant wrote:
> On Tuesday, Aug 5, 2003, at 17:29 Europe/London, Michael Chamberlain
> wrote:
>
>> Hi guys
>>
>> This bugs new in 1.6.2 and it pretty much renders 1.6.2 unusable. Can
>> I make a
>> suggestion we release a 1.6.3 quickly before too many people pick it
>> up.
>
> Can you write a test for it that demonstrates the bug?
>
>
OK I've got a test which demonstrates it, it only affects stuff if you
have something
as a global style AND are using <AxMediaType / <AxStyleName directives.
Now before I go polluting the cvs repository with lots of directories,
everyone happy
with me adding
t/component/configreader
t/htdocs/component/configreader
t/htdocs/style/component/configreader
as directories...
or would
t/configreader etc....
be preferred?
Mike.
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Matt Sergeant <ma...@sergeant.org>.
On Tuesday, Aug 5, 2003, at 17:29 Europe/London, Michael Chamberlain
wrote:
> Hi guys
>
> This bugs new in 1.6.2 and it pretty much renders 1.6.2 unusable. Can
> I make a
> suggestion we release a 1.6.3 quickly before too many people pick it
> up.
Can you write a test for it that demonstrates the bug?
Matt.
Re: cvs commit: xml-axkit/lib/Apache/AxKit ConfigReader.pm
Posted by Michael Chamberlain <mi...@btinternet.com>.
Hi guys
This bugs new in 1.6.2 and it pretty much renders 1.6.2 unusable. Can I
make a
suggestion we release a 1.6.3 quickly before too many people pick it up.
Mike.
On Tuesday, August 5, 2003, at 12:05 am, mach@apache.org wrote:
> mach 2003/08/04 16:05:17
>
> Modified: lib/Apache/AxKit ConfigReader.pm
> Log:
> Fixing styles leaking into #global style cache. (subsequent
> requests would see styles from previous requests).
>
> Revision Changes Path
> 1.18 +6 -2 xml-axkit/lib/Apache/AxKit/ConfigReader.pm
>
> Index: ConfigReader.pm
> ===================================================================
> RCS file: /home/cvs/xml-axkit/lib/Apache/AxKit/ConfigReader.pm,v
> retrieving revision 1.17
> retrieving revision 1.18
> diff -u -r1.17 -r1.18
> --- ConfigReader.pm 11 Jul 2003 16:03:54 -0000 1.17
> +++ ConfigReader.pm 4 Aug 2003 23:05:17 -0000 1.18
> @@ -384,7 +384,11 @@
> $style ||= '#default';
>
> # Add global styles
> - my $list = $self->{cfg}{Processors}{$media}{'#global'} || [];
> + my $list = [];
> +
> + if( exists($self->{cfg}{Processors}{$media}{'#global'})) {
> + push @$list, @{ $self->{cfg}{Processors}{$media}{'#global'} || []};
> + }
>
> # Add styles matching this style
> if (exists($self->{cfg}{Processors}{$media}{$style})) {
>
>
>
>