You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2017/01/19 17:48:34 UTC
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5745
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
RECOVER PARTITIONS needs to avoid recovering partitions that are
already in HMS. Before this patch, that check is done by makeing a
list of the existing partitions and searching in that list for each
path found in the search for partitions eligible for recovery. This
patch changes the container to a HashSet for performance reasons.
Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/5745/1
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
Patch Set 1: Verified+1
http://jenkins.impala.io:8080/job/parallel-all-tests/218/
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
Patch Set 1:
> Testing at: http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/646/
All tests passed: http://jenkins.impala.io:8080/job/parallel-all-tests/218/
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
Patch Set 1:
Testing at: http://jenkins.impala.io:8080/job/ubuntu-14.04-from-scratch/646/
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
......................................................................
IMPALA-4788: Use HashSet in RECOVER PARTITIONS duplicate checks
RECOVER PARTITIONS needs to avoid recovering partitions that are
already in HMS. Before this patch, that check is done by makeing a
list of the existing partitions and searching in that list for each
path found in the search for partitions eligible for recovery. This
patch changes the container to a HashSet for performance reasons.
Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Reviewed-on: http://gerrit.cloudera.org:8080/5745
Reviewed-by: Alex Behm <al...@cloudera.com>
Reviewed-by: Marcel Kornacker <ma...@cloudera.com>
Tested-by: Jim Apple <jb...@apache.org>
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Marcel Kornacker: Looks good to me, approved
Jim Apple: Verified
Alex Behm: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/5745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b9b6f8eb85f854e8c0896c18a231cebe32b4678
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>