You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/17 20:52:43 UTC

[GitHub] [fineract] vidakovic commented on a change in pull request #1418: FINERACT-1207: Clean up fineract-provider/config/swagger following in…

vidakovic commented on a change in pull request #1418:
URL: https://github.com/apache/fineract/pull/1418#discussion_r506982939



##########
File path: .gitignore
##########
@@ -21,3 +21,4 @@ fineract-provider/src/main/resources/application.properties
 fineract-provider/out/
 fineract-provider/config/swagger/config.json
 fineract-provider/config/swagger/fineract-input.yaml
+fineract-client/config/swagger/templates/*.mustache

Review comment:
       @vorburger It is. That way you can still give advanced users the option to add their own templates if they need something custom we don't support. There's also a disclaimer in the client doc that we don't manage any custom templates.
   
   I've added that reading the previous doc where this was described as some kind of feature. If we don't want that then I can remove again.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org