You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Prakash Khemani (Created) (JIRA)" <ji...@apache.org> on 2012/03/22 17:40:22 UTC
[jira] [Created] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
SplitLogManager - prevent unnecessary attempts to resubmits
-----------------------------------------------------------
Key: HBASE-5618
URL: https://issues.apache.org/jira/browse/HBASE-5618
Project: HBase
Issue Type: Improvement
Reporter: Prakash Khemani
Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
Two changes should be made
(1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
(2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245833#comment-13245833 ]
Hadoop QA commented on HBASE-5618:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521225/0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestColumnSeeking
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1380//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1380//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1380//console
This message is automatically generated.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249445#comment-13249445 ]
Hudson commented on HBASE-5618:
-------------------------------
Integrated in HBase-TRUNK #2727 (See [https://builds.apache.org/job/HBase-TRUNK/2727/])
HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310923)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Prakash Khemani (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245790#comment-13245790 ]
Prakash Khemani commented on HBASE-5618:
----------------------------------------
sorry for the test failure. fixed and verified.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5618:
----------------------------------
Status: Patch Available (was: Open)
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245466#comment-13245466 ]
Hadoop QA commented on HBASE-5618:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520020/0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1377//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1377//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1377//console
This message is automatically generated.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5618:
-------------------------
Status: Patch Available (was: Open)
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5618:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
0.92.2
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Applied to 0.92, 0.94 and trunk. Thanks for the patch Prakash.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245485#comment-13245485 ]
stack commented on HBASE-5618:
------------------------------
That test failure don't look too good.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259508#comment-13259508 ]
Hudson commented on HBASE-5618:
-------------------------------
Integrated in HBase-0.92-security #105 (See [https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310921)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-5618:
-----------------------------------
Attachment: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249478#comment-13249478 ]
Hudson commented on HBASE-5618:
-------------------------------
Integrated in HBase-TRUNK-security #162 (See [https://builds.apache.org/job/HBase-TRUNK-security/162/])
HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310923)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-5618:
-----------------------------------
Attachment: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
patch without directory prefixes
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Prakash Khemani (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246874#comment-13246874 ]
Prakash Khemani commented on HBASE-5618:
----------------------------------------
TestColumnSeeking isn't failing for me.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Prakash Khemani (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani reassigned HBASE-5618:
--------------------------------------
Assignee: Prakash Khemani
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-5618:
-----------------------------------
Attachment: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
re-attaching the same patch. I had cancelled it by mistake.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249018#comment-13249018 ]
Hadoop QA commented on HBASE-5618:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521428/0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1441//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1441//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1441//console
This message is automatically generated.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-5618:
-----------------------------------
Status: Open (was: Patch Available)
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249464#comment-13249464 ]
Hudson commented on HBASE-5618:
-------------------------------
Integrated in HBase-0.92 #362 (See [https://builds.apache.org/job/HBase-0.92/362/])
HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310921)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249417#comment-13249417 ]
stack commented on HBASE-5618:
------------------------------
I tried the above failing test locally and it passed for me.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-5618:
-----------------------------------
Attachment: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
update "heartbeat time" as soon as possible and as often as one can.
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253619#comment-13253619 ]
Hudson commented on HBASE-5618:
-------------------------------
Integrated in HBase-0.94-security #9 (See [https://builds.apache.org/job/HBase-0.94-security/9/])
HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310922)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249452#comment-13249452 ]
Hudson commented on HBASE-5618:
-------------------------------
Integrated in HBase-0.94 #98 (See [https://builds.apache.org/job/HBase-0.94/98/])
HBASE-5618 SplitLogManager - prevent unnecessary attempts to resubmits (Revision 1310922)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.2, 0.94.0
>
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5618:
----------------------------------
Component/s: zookeeper
wal
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5618) SplitLogManager - prevent
unnecessary attempts to resubmits
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245399#comment-13245399 ]
stack commented on HBASE-5618:
------------------------------
+1 on patch
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5618) SplitLogManager - prevent unnecessary
attempts to resubmits
Posted by "Prakash Khemani (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakash Khemani updated HBASE-5618:
-----------------------------------
Attachment: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
> SplitLogManager - prevent unnecessary attempts to resubmits
> -----------------------------------------------------------
>
> Key: HBASE-5618
> URL: https://issues.apache.org/jira/browse/HBASE-5618
> Project: HBase
> Issue Type: Improvement
> Components: wal, zookeeper
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch, 0001-HBASE-5618-SplitLogManager-prevent-unnecessary-attem.patch
>
>
> Currently once a watch fires that the task node has been updated (hearbeated) by the worker, the splitlogmanager still quite some time before it updates the "last heard from" time. This is because the manager currently schedules another getDataSetWatch() and only after that finishes will it update the task's "last heard from" time.
> This leads to a large number of zk-BadVersion warnings when resubmission is continuously attempted and it fails.
> Two changes should be made
> (1) On a resubmission failure because of BadVersion the task's lastUpdate time should get upped.
> (2) The task's lastUpdate time should get upped as soon as the nodeDataChanged() watch fires and without waiting for getDataSetWatch() to complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira