You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Concini (JIRA)" <de...@myfaces.apache.org> on 2009/04/14 20:17:14 UTC

[jira] Created: (MYFACES-2198) remaining FacesContext/FacesContextImpl TODOs.

remaining FacesContext/FacesContextImpl TODOs.
----------------------------------------------

                 Key: MYFACES-2198
                 URL: https://issues.apache.org/jira/browse/MYFACES-2198
             Project: MyFaces Core
          Issue Type: Task
          Components: JSR-314
    Affects Versions: 2.0.0-alpha
            Reporter: Michael Concini
            Priority: Minor


handle remaining todos in FacesContext and FacesContextImpl. 

Includes cleaning up of FacesContext TODO: IMPLEMENENT IMPL markers that have already been handled in the impl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MYFACES-2198) remaining FacesContext/FacesContextImpl TODOs.

Posted by "Michael Concini (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Concini updated MYFACES-2198:
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-alpha
           Status: Resolved  (was: Patch Available)

> remaining FacesContext/FacesContextImpl TODOs.
> ----------------------------------------------
>
>                 Key: MYFACES-2198
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2198
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Concini
>            Priority: Minor
>             Fix For: 2.0.0-alpha
>
>         Attachments: MYFACES-2198.patch
>
>
> handle remaining todos in FacesContext and FacesContextImpl. 
> Includes cleaning up of FacesContext TODO: IMPLEMENENT IMPL markers that have already been handled in the impl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MYFACES-2198) remaining FacesContext/FacesContextImpl TODOs.

Posted by "Michael Concini (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Concini updated MYFACES-2198:
-------------------------------------

    Status: Patch Available  (was: Open)

> remaining FacesContext/FacesContextImpl TODOs.
> ----------------------------------------------
>
>                 Key: MYFACES-2198
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2198
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Concini
>            Priority: Minor
>         Attachments: MYFACES-2198.patch
>
>
> handle remaining todos in FacesContext and FacesContextImpl. 
> Includes cleaning up of FacesContext TODO: IMPLEMENENT IMPL markers that have already been handled in the impl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2198) remaining FacesContext/FacesContextImpl TODOs.

Posted by "Michael Concini (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698908#action_12698908 ] 

Michael Concini commented on MYFACES-2198:
------------------------------------------

working on it.  While I'm updating FacesContextImpl, I agree with Simon that updating the messages lists to use a Map<String, List<FacesMessage>> construct would be more efficient than two lists.  I'll make that change while I'm in there.  

> remaining FacesContext/FacesContextImpl TODOs.
> ----------------------------------------------
>
>                 Key: MYFACES-2198
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2198
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Concini
>            Priority: Minor
>
> handle remaining todos in FacesContext and FacesContextImpl. 
> Includes cleaning up of FacesContext TODO: IMPLEMENENT IMPL markers that have already been handled in the impl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (MYFACES-2198) remaining FacesContext/FacesContextImpl TODOs.

Posted by "Michael Concini (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700791#action_12700791 ] 

Michael Concini edited comment on MYFACES-2198 at 4/20/09 6:45 AM:
-------------------------------------------------------------------

Patch includes the following:
removed getFlash from FacesContext/FacesContextWrapper since it is not in the API per proposed final draft spec.  

Completed all methods in FacesConterxtImpl.  Created PartialViewContextFactoryImpl and PartialViewContextImpl.  

All methods completed for PartialViewContextImpl except for processPartial, which will take some additional time and is outside the scope of what this issue was opened for.  

I reused getRequestParameterList from SImon's code that had been commented from the former internal PartialViewContextImpl class.  

      was (Author: mconcini):
    Patch includes the following:
removed getFlash from FacesContext/FacesContextWrapper since it is not in the API per proposed final draft spec.  

Completed all methods in FacesConterxtImpl.  Created PartialViewContextFactoryImpl and PartialViewContextImpl.  

All methods completed for PartialViewContextImpl except for processPartial, which will take some additional time and is outside the scope of what this issue was opened for.  
  
> remaining FacesContext/FacesContextImpl TODOs.
> ----------------------------------------------
>
>                 Key: MYFACES-2198
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2198
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Concini
>            Priority: Minor
>         Attachments: MYFACES-2198.patch
>
>
> handle remaining todos in FacesContext and FacesContextImpl. 
> Includes cleaning up of FacesContext TODO: IMPLEMENENT IMPL markers that have already been handled in the impl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.