You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Steve hammond (JIRA)" <ji...@apache.org> on 2009/02/18 19:06:01 UTC
[jira] Created: (DIRSHARED-25) BranchNormalizedVisitor cannot
handle Nots
BranchNormalizedVisitor cannot handle Nots
------------------------------------------
Key: DIRSHARED-25
URL: https://issues.apache.org/jira/browse/DIRSHARED-25
Project: Directory Shared
Issue Type: Bug
Affects Versions: 0.9.11
Reporter: Steve hammond
SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a not in the clause.
To fix it I removed the (if NotNode) return null. And all was well.
I tried to add the following test to BranchNormalizedVisitorTest
public void testBranchNormalizedVisitor4() throws Exception
{
ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))" );
ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))" );
BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
visitor.visit( altered );
assertTrue( ori.toString().equals( altered.toString() ) );
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSHARED-25) BranchNormalizedVisitor cannot
handle Nots
Posted by "Steve hammond (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve hammond updated DIRSHARED-25:
-----------------------------------
Attachment: BranchNorm.patch
> BranchNormalizedVisitor cannot handle Nots
> ------------------------------------------
>
> Key: DIRSHARED-25
> URL: https://issues.apache.org/jira/browse/DIRSHARED-25
> Project: Directory Shared
> Issue Type: Bug
> Affects Versions: 0.9.11
> Reporter: Steve hammond
> Attachments: BranchNorm.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a not in the clause.
> To fix it I removed the (if NotNode) return null. And all was well.
> I tried to add the following test to BranchNormalizedVisitorTest
> public void testBranchNormalizedVisitor4() throws Exception
> {
> ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))" );
> ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))" );
> BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
> visitor.visit( altered );
> assertTrue( ori.toString().equals( altered.toString() ) );
>
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSHARED-25) BranchNormalizedVisitor cannot
handle Nots
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSHARED-25:
---------------------------------------
Fix Version/s: 0.9.14
> BranchNormalizedVisitor cannot handle Nots
> ------------------------------------------
>
> Key: DIRSHARED-25
> URL: https://issues.apache.org/jira/browse/DIRSHARED-25
> Project: Directory Shared
> Issue Type: Bug
> Affects Versions: 0.9.11
> Reporter: Steve hammond
> Assignee: Emmanuel Lecharny
> Fix For: 0.9.14
>
> Attachments: BranchNorm.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a not in the clause.
> To fix it I removed the (if NotNode) return null. And all was well.
> I tried to add the following test to BranchNormalizedVisitorTest
> public void testBranchNormalizedVisitor4() throws Exception
> {
> ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))" );
> ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))" );
> BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
> visitor.visit( altered );
> assertTrue( ori.toString().equals( altered.toString() ) );
>
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DIRSHARED-25) BranchNormalizedVisitor cannot
handle Nots
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny reassigned DIRSHARED-25:
------------------------------------------
Assignee: Emmanuel Lecharny
> BranchNormalizedVisitor cannot handle Nots
> ------------------------------------------
>
> Key: DIRSHARED-25
> URL: https://issues.apache.org/jira/browse/DIRSHARED-25
> Project: Directory Shared
> Issue Type: Bug
> Affects Versions: 0.9.11
> Reporter: Steve hammond
> Assignee: Emmanuel Lecharny
> Attachments: BranchNorm.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a not in the clause.
> To fix it I removed the (if NotNode) return null. And all was well.
> I tried to add the following test to BranchNormalizedVisitorTest
> public void testBranchNormalizedVisitor4() throws Exception
> {
> ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))" );
> ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))" );
> BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
> visitor.visit( altered );
> assertTrue( ori.toString().equals( altered.toString() ) );
>
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSHARED-25) BranchNormalizedVisitor cannot
handle Nots
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRSHARED-25.
----------------------------------------
Resolution: Fixed
Patch applied in http://svn.apache.org/viewvc?view=rev&revision=746607 (4 months ago...)
Thanks Steve !
> BranchNormalizedVisitor cannot handle Nots
> ------------------------------------------
>
> Key: DIRSHARED-25
> URL: https://issues.apache.org/jira/browse/DIRSHARED-25
> Project: Directory Shared
> Issue Type: Bug
> Affects Versions: 0.9.11
> Reporter: Steve hammond
> Assignee: Emmanuel Lecharny
> Fix For: 0.9.14
>
> Attachments: BranchNorm.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> SearchRequestImpl uses BranchNormalizedVisitor and fails on comparisons if there is a not in the clause.
> To fix it I removed the (if NotNode) return null. And all was well.
> I tried to add the following test to BranchNormalizedVisitorTest
> public void testBranchNormalizedVisitor4() throws Exception
> {
> ExprNode ori = FilterParser.parse( "(&(!(sn=Bob))(ou=Human Resources)(uid=akarasulu))" );
> ExprNode altered = FilterParser.parse( "(&(ou=Human Resources)(uid=akarasulu)(!(sn=Bob)))" );
> BranchNormalizedVisitor visitor = new BranchNormalizedVisitor();
> visitor.visit( altered );
> assertTrue( ori.toString().equals( altered.toString() ) );
>
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.