[GitHub] [incubator-dubbo] beiwei30 commented on issue #2795: 如何关闭 dubbo telnet调试功能

["beiwei30 (GitHub)" <gi...@apache.org>]

I believe #2925 from @kexianjun should satisfy this particular requirement, to disable telnet, simply configure 

```xml
<dubbo:protocol name="dubbo" port="20890" telnet="help"/>
```

In this way, only `help` is available for executing, and other commands are disabled.

I don't agree with the idea of introducing another flag to control this func. A better way to disable telent should be:

```xml
<dubbo:protocol name="dubbo" port="20890" telnet="disabled"/>
```

Then we can use this magic word `disabled` in org.apache.dubbo.remoting.telnet.support.TelnetHandlerAdapter to return immediately. 

What do you think, Guys?

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2795 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org