You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mateiz <gi...@git.apache.org> on 2014/04/06 00:08:12 UTC

[GitHub] spark pull request: Spark 615 map partitions with index callable f...

Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16#discussion_r11323506
  
    --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala ---
    @@ -72,11 +72,12 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]] extends Serializable {
        * Return a new RDD by applying a function to each partition of this RDD, while tracking the index
        * of the original partition.
        */
    -  def mapPartitionsWithIndex[R: ClassTag](
    --- End diff --
    
    Try updating this to just take a `Function2<Integer, java.util.Iterator<A>, java.util.Iterator<B>>`. I'm pretty sure it would work and we won't need a new type of class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---