You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2015/09/09 15:30:20 UTC
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1112
[FLINK-2645][jobmanager] forward exceptions when merging final accumlator results
- fix forwarding
- add test case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink accumulator-exceptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1112
----
commit 387fa5e4021185753c950498b1c2e7a8d44223e5
Author: Maximilian Michels <mx...@apache.org>
Date: 2015-09-09T11:49:40Z
[FLINK-2645][jobmanager] forward exceptions when merging final accumulators
- add test case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-138976625
Thanks for the review. I've since extended this pull request. Upon failure to deserialize the final task accumulator results, we now fail `Executions` and forward the Exception instead of just logging them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-139127959
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1112#discussion_r39073704
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java ---
@@ -922,19 +922,18 @@ public boolean updateState(TaskExecutionState state) {
case RUNNING:
return attempt.switchToRunning();
case FINISHED:
- Map<AccumulatorRegistry.Metric, Accumulator<?, ?>> flinkAccumulators = null;
- Map<String, Accumulator<?, ?>> userAccumulators = null;
try {
AccumulatorSnapshot accumulators = state.getAccumulators();
- flinkAccumulators = accumulators.deserializeFlinkAccumulators();
- userAccumulators = accumulators.deserializeUserAccumulators(userClassLoader);
+ Map<AccumulatorRegistry.Metric, Accumulator<?, ?>> flinkAccumulators =
+ accumulators.deserializeFlinkAccumulators();
+ Map<String, Accumulator<?, ?>> userAccumulators =
+ accumulators.deserializeUserAccumulators(userClassLoader);
+ attempt.markFinished(flinkAccumulators, userAccumulators);
}
catch (Exception e) {
- // we do not fail the job on deserialization problems of accumulators, but only log
LOG.error("Failed to deserialize final accumulator results.", e);
+ attempt.markFailed(new SerializedThrowable(e));
--- End diff --
I don't think you need a SerializedThrowable here. The exceptions are wrapped in serialized throwables when they are transported via actor messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-138988378
Looks good, modulo the one inline comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-139189765
+1, will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2645][jobmanager] forward exceptions wh...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-138950226
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---