[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2248: refactor: Replace futures with futures-util

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #2248:
URL: https://github.com/apache/incubator-opendal/pull/2248#discussion_r1189333193


##########
Cargo.lock:
##########
@@ -2538,7 +2538,7 @@ dependencies = [
  "chrono",
  "clap 4.2.5",
  "dirs 5.0.0",
- "futures",
+ "futures-util",

Review Comment:
   Thanks for the contribution. But I don't thin we can reduce deps via change `futures` into `futures-util`:
   
   diff of `futures` & `futures-util`'s dep:
   
   ```diff
   20,24c36,45
   < futures-channel = { path = "../futures-channel", version = "=0.4.0-alpha.0", default-features = false, features = ["sink"] }
   < futures-executor = { path = "../futures-executor", version = "=0.4.0-alpha.0", default-features = false, optional = true }
   < futures-io = { path = "../futures-io", version = "0.3.28", default-features = false }
   < futures-sink = { path = "../futures-sink", version = "=0.4.0-alpha.0", default-features = false }
   < futures-util = { path = "../futures-util", version = "=0.4.0-alpha.0", default-features = false, features = ["sink"] }
   ---
   > futures-channel = { path = "../futures-channel", version = "=0.4.0-alpha.0", default-features = false, features = ["std"], optional = true }
   > futures-io = { path = "../futures-io", version = "0.3.28", default-features = false, features = ["std"], optional = true }
   > futures-sink = { path = "../futures-sink", version = "=0.4.0-alpha.0", default-features = false, optional = true }
   > futures-macro = { path = "../futures-macro", version = "=0.4.0-alpha.0", default-features = false, optional = true }
   > slab = { version = "0.4.2", optional = true }
   > memchr = { version = "2.2", optional = true }
   > futures_01 = { version = "0.1.25", optional = true, package = "futures" }
   > tokio-io = { version = "0.1.9", optional = true }
   > pin-utils = "0.1.0"
   > pin-project-lite = "0.2.6"
   ```
   
   The only thing added here is `futures-executor`. I think we can remove it via disable the `executor` future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org