[GitHub] [iceberg] rdblue commented on a diff in pull request #6051: Core: Improve collection handling in JsonUtil

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6051:
URL: https://github.com/apache/iceberg/pull/6051#discussion_r1011983788


##########
core/src/main/java/org/apache/iceberg/util/JsonUtil.java:
##########
@@ -335,14 +348,16 @@ Integer convert(JsonNode element) {
     @Override
     void validate(JsonNode element) {
       Preconditions.checkArgument(
-          element.isInt(), "Cannot parse integer from non-int value: %s", element);
+          element.isInt(), "Cannot parse integer from non-int value: %s: %s", property, element);

Review Comment:
   Is this correct? This is an element in the array, not the array property itself. How about using `value in %s: %s` to be more clear?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org