[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4430: Cleanup un-necessary setups in HelixSetupUtils

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4430: Cleanup un-necessary setups in HelixSetupUtils
URL: https://github.com/apache/incubator-pinot/pull/4430#discussion_r303189673
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/util/TestUtils.java
 ##########
 @@ -140,35 +140,32 @@ public static void ensureDirectoriesExistAndEmpty(@Nonnull File... dirs)
    * @param timeoutMs Timeout in milliseconds
    * @param errorMessage Error message if condition is not met before timed out
    */
-  public static void waitForCondition(@Nonnull Function<Void, Boolean> condition, long checkIntervalMs, long timeoutMs,
-      @Nullable String errorMessage)
-      throws Exception {
+  public static void waitForCondition(Function<Void, Boolean> condition, long checkIntervalMs, long timeoutMs,
 
 Review comment:
   You should not put while loop inside the try-catch because the outer catch will catch the exception thrown out from the inner loop. Merged the error message check to one place (in the old code we also have two places to handle `errorMessage != null`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org