You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by cpoerschke <gi...@git.apache.org> on 2015/07/23 18:53:04 UTC
[GitHub] lucene-solr pull request: SOLR-7823: TestMiniSolrCloudCluster ... ...
GitHub user cpoerschke opened a pull request:
https://github.com/apache/lucene-solr/pull/195
SOLR-7823: TestMiniSolrCloudCluster ... async collection-creation (sometimes)
https://issues.apache.org/jira/i#browse/SOLR-7823
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-MiniSolrCloudCluster-createCollection-async
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/195.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #195
----
commit 8ccb213c9cebc07b17ff90d289a2000b66033c94
Author: Christine Poerschke <cp...@bloomberg.net>
Date: 2015-07-23T11:52:41Z
SOLR-????: TestMiniSolrCloudCluster.testCollectionCreateSearchDelete async collection-creation (sometimes)
summary of changes:
* adds MiniSolrCloudCluster.createCollection variant (with a 'String asyncId' parameter)
* AbstractFullDistribZkTestBase.getRequestState[AfterCompletion](...) now 'static' instead of 'protected'
* TestMiniSolrCloudCluster.testCollectionCreateSearchDelete sometimes uses async collection-creation (and then AbstractFullDistribZkTestBase.getRequestStateAfterCompletion waits for creation completion)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #195: SOLR-10047 - Fix test: Use NoMergePolicy in t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #195: SOLR-10047 - Fix test: Use NoMergePolicy in t...
Posted by chatman <gi...@git.apache.org>.
Github user chatman commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/195#discussion_r113005049
--- Diff: solr/core/src/test/org/apache/solr/schema/DocValuesEnabledLaterTest.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.schema;
+
+import java.lang.invoke.MethodHandles;
+
+import org.apache.lucene.document.Document;
+import org.apache.lucene.index.DirectoryReader;
+import org.apache.lucene.index.DocValuesType;
+import org.apache.lucene.index.FieldInfos;
+import org.apache.lucene.index.LeafReader;
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.index.MultiFields;
+import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.core.SolrCore;
+import org.apache.solr.index.NoMergePolicyFactory;
+import org.apache.solr.search.SolrIndexSearcher;
+import org.apache.solr.util.RefCounted;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class DocValuesEnabledLaterTest extends SolrTestCaseJ4 {
+
+ private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ @BeforeClass
+ public static void beforeTests() throws Exception {
+ initCore("solrconfig-basic.xml", "schema-docValues.xml");
+
+ // we need consistent segments that aren't re-ordered on merge because we're
+ // asserting inplace updates happen by checking the internal [docid]
--- End diff --
Lets remove references to inplace updates here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: SOLR-7823: TestMiniSolrCloudCluster ... ...
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke commented on the pull request:
https://github.com/apache/lucene-solr/pull/195#issuecomment-127662751
Committed (July 31st) to trunk and branch_5x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: SOLR-7823: TestMiniSolrCloudCluster ... ...
Posted by cpoerschke <gi...@git.apache.org>.
Github user cpoerschke closed the pull request at:
https://github.com/apache/lucene-solr/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org