You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2023/04/20 17:55:50 UTC
[GitHub] [spark] srielau opened a new pull request, #40884: [SPARK-43205] IDENTIFIER() Steel thread
srielau opened a new pull request, #40884:
URL: https://github.com/apache/spark/pull/40884
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179084897
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
+The purpose of this clause is to allow for templating of identifiers in SQL statements without opening up the risk of SQL injection attacks.
+
+### Syntax
+
+```sql
+IDENTIFIER ( str )
+```
+
+### Parameters
+
+* str: A STRING literal. Typically, the literal represented by a placeholder construct, such as a hive variable reference.
+
+### Notes
+
+While constant string expressions are not supported you can combine multiple string literals into one by chaining them: ‘hello’ ‘world’ is equivalent to ‘helloworld’.
+This allows parameterization of partial strings such as ‘prefix_’ ${ hivevar:x } ‘_postfix’.
+
+Different tools support different syntax for text substitution. For example a Notebook may use { { parameter } }.
+
+### Examples
+
+```sql
+-- Using a Hive variable in Databricks Runtime
+SET hivevar:tab = ‘T’;
Review Comment:
It's a common problem when we copy something from Google doc or Microsoft word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on PR #40884:
URL: https://github.com/apache/spark/pull/40884#issuecomment-1522534258
@cloud-fan How are docs done? Attach them to the same PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179190092
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
Review Comment:
It's a game of whack-a-mole. I did not cover all places. And I'm unsure how feasible it is to cover all (and keep them covered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179082332
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
Review Comment:
Shall we be more clear here? I think we can say that this clause can be used anywhere that an expression can be used, and will be converted into an unresolved column. In addition, it can also be used where a table identifier is used, such as FROM tbl, CREATE TABLE tbl, and will be converted into an unresolved relation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1178121404
##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -798,9 +798,19 @@ multipartIdentifierList
;
multipartIdentifier
- : parts+=errorCapturingIdentifier (DOT parts+=errorCapturingIdentifier)*
+ : parts+=errorCapturingIdentifierWithTemplate (DOT parts+=errorCapturingIdentifierWithTemplate)*
;
+errorCapturingIdentifierWithTemplate
+ : identifierClause
+ | ident = errorCapturingIdentifier
+ ;
+
+errorCapturingSingleIdentifierWithTemplate
Review Comment:
The SingleIdentifier versions raise an error if the string literal passed to IDENTIFIER() parses as a qualified name.
They also produce a String. Where the others produce a Seq[String]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1178121878
##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -798,9 +798,19 @@ multipartIdentifierList
;
multipartIdentifier
- : parts+=errorCapturingIdentifier (DOT parts+=errorCapturingIdentifier)*
+ : parts+=errorCapturingIdentifierWithTemplate (DOT parts+=errorCapturingIdentifierWithTemplate)*
;
+errorCapturingIdentifierWithTemplate
+ : identifierClause
+ | ident = errorCapturingIdentifier
+ ;
+
+errorCapturingSingleIdentifierWithTemplate
Review Comment:
PS: I'm no fan of then names I used. VERY open to better proposals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179083715
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
+The purpose of this clause is to allow for templating of identifiers in SQL statements without opening up the risk of SQL injection attacks.
+
+### Syntax
+
+```sql
+IDENTIFIER ( str )
+```
+
+### Parameters
+
+* str: A STRING literal. Typically, the literal represented by a placeholder construct, such as a hive variable reference.
+
+### Notes
+
+While constant string expressions are not supported you can combine multiple string literals into one by chaining them: ‘hello’ ‘world’ is equivalent to ‘helloworld’.
+This allows parameterization of partial strings such as ‘prefix_’ ${ hivevar:x } ‘_postfix’.
+
+Different tools support different syntax for text substitution. For example a Notebook may use { { parameter } }.
+
+### Examples
+
+```sql
+-- Using a Hive variable in Databricks Runtime
+SET hivevar:tab = ‘T’;
Review Comment:
ditto, we should use `'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179190092
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
Review Comment:
It's a game of whack-a-mole. I did not cover all places. I did not cover all places, And I'm unsure how feasible it is to cover all (and keep them covered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179079359
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
+The purpose of this clause is to allow for templating of identifiers in SQL statements without opening up the risk of SQL injection attacks.
+
+### Syntax
+
+```sql
+IDENTIFIER ( str )
+```
+
+### Parameters
+
+* str: A STRING literal. Typically, the literal represented by a placeholder construct, such as a hive variable reference.
+
+### Notes
+
+While constant string expressions are not supported you can combine multiple string literals into one by chaining them: ‘hello’ ‘world’ is equivalent to ‘helloworld’.
+This allows parameterization of partial strings such as ‘prefix_’ ${ hivevar:x } ‘_postfix’.
Review Comment:
```suggestion
This allows parameterization of partial strings such as 'prefix_' ${ hivevar:x } '_postfix'.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1179191177
##########
docs/sql-ref-identifier-clause.md:
##########
@@ -0,0 +1,70 @@
+---
+layout: global
+title: Identifier clause
+displayTitle: IDENTIFIER clause
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+Convert a STRING literal into an identifier or name. The IDENTIFIER clause can be used in many places instead of, or in combination with identifiers where identifiers or names are used.
+The purpose of this clause is to allow for templating of identifiers in SQL statements without opening up the risk of SQL injection attacks.
+
+### Syntax
+
+```sql
+IDENTIFIER ( str )
+```
+
+### Parameters
+
+* str: A STRING literal. Typically, the literal represented by a placeholder construct, such as a hive variable reference.
+
+### Notes
+
+While constant string expressions are not supported you can combine multiple string literals into one by chaining them: ‘hello’ ‘world’ is equivalent to ‘helloworld’.
+This allows parameterization of partial strings such as ‘prefix_’ ${ hivevar:x } ‘_postfix’.
+
+Different tools support different syntax for text substitution. For example a Notebook may use { { parameter } }.
+
+### Examples
+
+```sql
+-- Using a Hive variable in Databricks Runtime
+SET hivevar:tab = ‘T’;
Review Comment:
```suggestion
SET hivevar:tab = 'T';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40884: [SPARK-43205] IDENTIFIER() clause
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40884:
URL: https://github.com/apache/spark/pull/40884#discussion_r1177985939
##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -798,9 +798,19 @@ multipartIdentifierList
;
multipartIdentifier
- : parts+=errorCapturingIdentifier (DOT parts+=errorCapturingIdentifier)*
+ : parts+=errorCapturingIdentifierWithTemplate (DOT parts+=errorCapturingIdentifierWithTemplate)*
;
+errorCapturingIdentifierWithTemplate
+ : identifierClause
+ | ident = errorCapturingIdentifier
+ ;
+
+errorCapturingSingleIdentifierWithTemplate
Review Comment:
what's the difference between this and `errorCapturingIdentifierWithTemplate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org