(superset) branch ci/bashlib-drop-dead-nonce-bc created (now 2df94c2fc40)

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a change to branch ci/bashlib-drop-dead-nonce-bc
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 2df94c2fc40 ci(bashlib): drop the dead `bc`-based NONCE computation

This branch includes the following new commits:

     new 2df94c2fc40 ci(bashlib): drop the dead `bc`-based NONCE computation

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(superset) 01/01: ci(bashlib): drop the dead `bc`-based NONCE computation

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch ci/bashlib-drop-dead-nonce-bc
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 2df94c2fc401f8cd5dcc3f993d1ef4faaf8ca12f
Author: Evan <ev...@preset.io>
AuthorDate: Tue Jun 2 14:10:14 2026 -0700

    ci(bashlib): drop the dead `bc`-based NONCE computation
    
    `NONCE` is computed at the top level of bashlib.sh on every source (two
    `date` subshells plus an external `bc`), but it is never referenced
    anywhere in the repo — it's dead code.
    
    Beyond the wasted subshells on every cached-dependencies invocation, it's
    a reliability hazard: bashlib runs under `set -e`, so if `bc` is missing
    on a runner image (or the expression errors), sourcing aborts at this
    line — before later shortcuts like `build-embedded-sdk`,
    `build-instrumented-assets`, and the cypress helpers are defined. The
    action then runs the requested shortcut and fails with
    `<cmd>: command not found` (exit 127), which shows up as intermittent
    "Build embedded SDK" playwright failures.
    
    Removing the unused line is a no-op behaviorally and removes both the
    per-source cost and the failure mode.
    
    Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
 .github/workflows/bashlib.sh | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.github/workflows/bashlib.sh b/.github/workflows/bashlib.sh
index 569d3b0a22c..b7be35f7585 100644
--- a/.github/workflows/bashlib.sh
+++ b/.github/workflows/bashlib.sh
@@ -20,10 +20,6 @@ set -e
 GITHUB_WORKSPACE=${GITHUB_WORKSPACE:-.}
 ASSETS_MANIFEST="$GITHUB_WORKSPACE/superset/static/assets/manifest.json"
 
-# Rounded job start time, used to create a unique Cypress build id for
-# parallelization so we can manually rerun a job after 20 minutes
-NONCE=$(echo "$(date "+%Y%m%d%H%M") - ($(date +%M)%20)" | bc)
-
 # Echo only when not in parallel mode
 say() {
   if [[ $(echo "$INPUT_PARALLEL" | tr '[:lower:]' '[:upper:]') != 'TRUE' ]]; then