You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/07 13:18:57 UTC

[GitHub] [airflow] kaxil commented on pull request #16284: Make TriggerDagRunOperator compatible with taskflow API

kaxil commented on pull request #16284:
URL: https://github.com/apache/airflow/pull/16284#issuecomment-855920447


   > > We will need to find a better way for #13414 in that case :(
   > 
   > Right, the issue was even then mentioned explicitly [#13414 (comment)](https://github.com/apache/airflow/issues/13414#issuecomment-776173348).
   > 
   > I'm wondering if we should introduce `airflow.json` module that would be able to handle some Airflow-known objects. I think reusing DAG serialization code may help. WDYT @kaxil ?
   
   Two related issues but we might able to fix both -- (1) the UI one currently fails at https://github.com/apache/airflow/blob/bff213e07735d1ee45101f85b01b3d3a97cddbe5/airflow/www/views.py#L2073 and other places where `alchemy_to_dict` is used in that file.
   
   (2) Using DAG Serialization for storing values in XCom (https://github.com/apache/airflow/issues/8703)
   
   (1)st is a bit more involved -- I tried something quick in https://github.com/apache/airflow/pull/13964 in which fixed #13414 but needed lot of hardcoding so opted for let's now allow arbitrary values in `TriggerDagRunOperator` which is what we allow when we trigger DAG manually in the UI too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org