You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/02/10 04:23:52 UTC
Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14987
https://issues.apache.org/jira/browse/AMBARI-14987
Repository: ambari
Description
-------
On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
The fix would also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
Diffs
-----
ambari-web/app/assets/test/tests.js ecf55f7
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
ambari-web/test/controllers/wizard/step5_test.js a2bc687
ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43402/diff/
Testing
-------
Manually Tested.
Unit tests passed:
24226 tests complete (20 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.492 s
[INFO] Finished at: 2016-02-09T19:10:48-08:00
[INFO] Final Memory: 14M/428M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Matt <mi...@gmail.com>.
> On Feb. 10, 2016, 4:33 p.m., jun aoki wrote:
> > ambari-web/app/mixins/wizard/assign_master_components.js, line 685
> > <https://reviews.apache.org/r/43402/diff/2/?file=1239799#file1239799line685>
> >
> > line 680 - 682 of the original is extracted into local variables. Here, and the line 682 of patch is adding a new condition when to show master components. Is it right?
Yes that's right.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118777
-----------------------------------------------------------
On Feb. 10, 2016, 11:58 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:58 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
>
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js ecf55f7
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
> ambari-web/test/controllers/wizard/step5_test.js a2bc687
> ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43402/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Unit tests passed:
> 24227 tests complete (21 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118777
-----------------------------------------------------------
ambari-web/app/mixins/wizard/assign_master_components.js (line 678)
<https://reviews.apache.org/r/43402/#comment180090>
line 680 - 682 of the original is extracted into local variables. Here, and the line 682 of patch is adding a new condition when to show master components. Is it right?
- jun aoki
On Feb. 10, 2016, 7:58 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:58 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
>
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js ecf55f7
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
> ambari-web/test/controllers/wizard/step5_test.js a2bc687
> ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43402/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Unit tests passed:
> 24227 tests complete (21 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118739
-----------------------------------------------------------
Ship it!
Ship It!
- Lav Jain
On Feb. 10, 2016, 7:58 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:58 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
>
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js ecf55f7
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
> ambari-web/test/controllers/wizard/step5_test.js a2bc687
> ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43402/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Unit tests passed:
> 24227 tests complete (21 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118762
-----------------------------------------------------------
Ship it!
Ship It!
- Goutam Tadi
On Feb. 10, 2016, 7:58 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:58 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
>
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js ecf55f7
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
> ambari-web/test/controllers/wizard/step5_test.js a2bc687
> ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43402/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Unit tests passed:
> 24227 tests complete (21 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Matt <mi...@gmail.com>.
> On Feb. 10, 2016, 4:34 p.m., jun aoki wrote:
> > ambari-web/test/controllers/wizard/step5_test.js, line 1040
> > <https://reviews.apache.org/r/43402/diff/2/?file=1239800#file1239800line1040>
> >
> > this is good that we extracted the test to a dedicated test js file.
There was no reason to have it tied to the test of the controller. Moved it to its own test location.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118778
-----------------------------------------------------------
On Feb. 10, 2016, 11:58 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 11:58 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
>
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js ecf55f7
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
> ambari-web/test/controllers/wizard/step5_test.js a2bc687
> ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43402/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Unit tests passed:
> 24227 tests complete (21 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/#review118778
-----------------------------------------------------------
ambari-web/test/controllers/wizard/step5_test.js
<https://reviews.apache.org/r/43402/#comment180092>
this is good that we extracted the test to a dedicated test js file.
- jun aoki
On Feb. 10, 2016, 7:58 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43402/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 7:58 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
>
> This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
> The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js ecf55f7
> ambari-web/app/mixins/wizard/assign_master_components.js 0693507
> ambari-web/test/controllers/wizard/step5_test.js a2bc687
> ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43402/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Unit tests passed:
> 24227 tests complete (21 seconds)
> 156 tests pending
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48.026 s
> [INFO] Finished at: 2016-02-10T11:57:57-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 11:58 a.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14987
https://issues.apache.org/jira/browse/AMBARI-14987
Repository: ambari
Description
-------
On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
Diffs
-----
ambari-web/app/assets/test/tests.js ecf55f7
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
ambari-web/test/controllers/wizard/step5_test.js a2bc687
ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43402/diff/
Testing (updated)
-------
Manually Tested.
Unit tests passed:
24227 tests complete (21 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.026 s
[INFO] Finished at: 2016-02-10T11:57:57-08:00
[INFO] Final Memory: 12M/310M
[INFO] -----------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 11:35 a.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Changes
-------
Added additional test
Bugs: AMBARI-14987
https://issues.apache.org/jira/browse/AMBARI-14987
Repository: ambari
Description
-------
On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js ecf55f7
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
ambari-web/test/controllers/wizard/step5_test.js a2bc687
ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43402/diff/
Testing
-------
Manually Tested.
Unit tests passed:
24226 tests complete (20 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.492 s
[INFO] Finished at: 2016-02-09T19:10:48-08:00
[INFO] Final Memory: 14M/428M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43402: assign_master_component.js does not show
recommendations while adding master component for a service which is
already installed
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43402/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 7:24 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, Aleksandr Kovalenko, Alexandr Antonenko, bhuvnesh chaudhary, Goutam Tadi, Jaimin Jetly, jun aoki, Lav Jain, Newton Alex, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14987
https://issues.apache.org/jira/browse/AMBARI-14987
Repository: ambari
Description (updated)
-------
On the assign masters page for the wizard, recommendations are not shown for a master component that is being added for an installed service.
This happens while adding HAWQSTANDBY to the cluster using the 'Add HAWQSTANDBY' wizard (situation: HAWQ service is already installed on the cluster).
The fix might also solve the issue where there is a installed service and the upgrade of the service includes installing a new master component
Diffs
-----
ambari-web/app/assets/test/tests.js ecf55f7
ambari-web/app/mixins/wizard/assign_master_components.js 0693507
ambari-web/test/controllers/wizard/step5_test.js a2bc687
ambari-web/test/mixins/wizard/assign_master_components_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/43402/diff/
Testing
-------
Manually Tested.
Unit tests passed:
24226 tests complete (20 seconds)
156 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54.492 s
[INFO] Finished at: 2016-02-09T19:10:48-08:00
[INFO] Final Memory: 14M/428M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt