You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/10/04 19:24:10 UTC
[GitHub] [camel-quarkus] ffang opened a new issue #3154: QuarkusKafkaClientFactoryDisabledViaPropertiesTest is broken
ffang opened a new issue #3154:
URL: https://github.com/apache/camel-quarkus/issues/3154
If I have KAFKA_HOME environment variable like
```
export KAFKA_HOME=test
```
Then in the org.apache.camel.quarkus.component.kafka.KafkaClientFactoryProducer class, the kafkaConfig.isEmpty() returns false, since it has one entry "home=test", and QuarkusKafkaClientFactory instance will be created
Moreover, in application-configuration-disable-service-binding.properties, the
```
quarkus.kubernetes-service-binding.enabled=false
```
actually takes no effect(I assume when this property is false, Kafka configuration properties will not be discovered by the Quarkus Kubernetes Service Binding, but this isn't the case).
We can add more kafka properties into application-configuration-disable-service-binding.properties like
```
+kafka.client.id=camel-quarkus-client
+kafka.request.timeout.ms=1000
```
However, no matter what the value of quarkus.kubernetes-service-binding.enabled is, in the org.apache.camel.quarkus.component.kafka.KafkaClientFactoryProducer class, the kafkaConfig always has these kafka property entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed issue #3154: QuarkusKafkaClientFactoryDisabledViaPropertiesTest is broken
Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #3154:
URL: https://github.com/apache/camel-quarkus/issues/3154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ffang commented on issue #3154: QuarkusKafkaClientFactoryDisabledViaPropertiesTest is broken
Posted by GitBox <gi...@apache.org>.
ffang commented on issue #3154:
URL: https://github.com/apache/camel-quarkus/issues/3154#issuecomment-936224312
@jamesnetherton yes, the patch fixes the issue I ran into.
Thanks!
Freeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3154: QuarkusKafkaClientFactoryDisabledViaPropertiesTest is broken
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3154:
URL: https://github.com/apache/camel-quarkus/issues/3154#issuecomment-935747230
@ffang You may want to test to see if https://github.com/apache/camel-quarkus/pull/3161 works for you before it gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org