You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lovexi <gi...@git.apache.org> on 2016/07/31 08:51:23 UTC

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Github user lovexi commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    Reopen PR #14415 @rxin 
    
    >> DId you add a test?
    
    I was trying to add a unit test for this feature. But the test sinks are not visible for MetricsSystem when it tries to register test sink classes since test sinks are hidden in test packages. Is there any other ways to load test classes for MetricsSystem without messed-up metrics package?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org