You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/08/21 07:12:57 UTC

[GitHub] sdedic closed pull request #729: [NETBEANS-1074] Module Review javascript2.nodejs

sdedic closed pull request #729: [NETBEANS-1074] Module Review javascript2.nodejs
URL: https://github.com/apache/incubator-netbeans/pull/729
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/javascript2.nodejs/external/binaries-list b/javascript2.nodejs/external/binaries-list
index 9490f90ec1..f3e4210ce4 100644
--- a/javascript2.nodejs/external/binaries-list
+++ b/javascript2.nodejs/external/binaries-list
@@ -1 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 39405F982F7D0E5D0932219BE1D91358D316D0AE javascript2.nodejs-nodejs-resources.zip
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc1.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc1.js
index d908bd6023..5533024aff 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc1.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc1.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc2.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc2.js
index 98715a505f..eed99e7001 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc2.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc2.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 var mod = require("../core/mymod");
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc4.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc4.js
index 5ccc55513b..6076ff0feb 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc4.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/cc4.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/foo.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/foo.js
index d814128ea5..4f049f2ae6 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/foo.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/cc/foo.js
@@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 exports.FreeList = function(name, max, constructor) {
   this.name = name;
   this.constructor = constructor;
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/core/mymod.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/core/mymod.js
index 8432e83a4c..20813d214b 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/core/mymod.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/core/mymod.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 function justCall(){
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arr.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arr.js
index b253b41331..90c9e11368 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arr.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arr.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arrRef.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arrRef.js
index bdf28c1081..1144f017ec 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arrRef.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/arrRef.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/newjavascript.js b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/newjavascript.js
index 502d68da06..dbe6bf4d82 100644
--- a/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/newjavascript.js
+++ b/javascript2.nodejs/test/qa-functional/data/SimpleNode/src/folder/newjavascript.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 var ee = req
diff --git a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/index.html b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/index.html
index c627c249c7..ae091c940d 100644
--- a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/index.html
+++ b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/index.html
@@ -1,9 +1,25 @@
 <!DOCTYPE html>
 <!--
-To change this license header, choose License Headers in Project Properties.
-To change this template file, choose Tools | Templates
-and open the template in the editor.
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
 -->
+
 <html>
     <head>
         <title>TODO supply a title</title>
diff --git a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue247565/folder/literalRef247565.js b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue247565/folder/literalRef247565.js
index d3a1aa6264..185c03ded7 100644
--- a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue247565/folder/literalRef247565.js
+++ b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue247565/folder/literalRef247565.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s1.js b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s1.js
index 80adb7f12b..b0ba709216 100644
--- a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s1.js
+++ b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s1.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s2.js b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s2.js
index b82ac1e4a7..53c8f8b836 100644
--- a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s2.js
+++ b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s2.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s3.js b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s3.js
index 8eb27adbe9..f334cd72f1 100644
--- a/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s3.js
+++ b/javascript2.nodejs/test/unit/data/TestNavigation/public_html/js/issue250329/s3.js
@@ -1,7 +1,20 @@
-/* 
- * To change this license header, choose License Headers in Project Properties.
- * To change this template file, choose Tools | Templates
- * and open the template in the editor.
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
  */
 
 
diff --git a/javascript2.nodejs/test/unit/src/org/netbeans/modules/javascript2/nodejs/editor/NodeJsDeclarationFinderTest.java b/javascript2.nodejs/test/unit/src/org/netbeans/modules/javascript2/nodejs/editor/NodeJsDeclarationFinderTest.java
index 7d87aa0fe4..514b210139 100644
--- a/javascript2.nodejs/test/unit/src/org/netbeans/modules/javascript2/nodejs/editor/NodeJsDeclarationFinderTest.java
+++ b/javascript2.nodejs/test/unit/src/org/netbeans/modules/javascript2/nodejs/editor/NodeJsDeclarationFinderTest.java
@@ -142,37 +142,37 @@ public void testIssue247565_08() throws Exception {
     
     @Test
     public void testIssue247565_09() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.ob^j.conf.a;", "literalRef247565.js", 415);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.ob^j.conf.a;", "literalRef247565.js", 1037);
     }
     
     @Test
     public void testIssue247565_10() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.co^nf.a;", "literalRef247565.js", 303);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.co^nf.a;", "literalRef247565.js", 925);
     }
     
     @Test
     public void testIssue247565_11() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.conf.a^;", "literalRef247565.js", 320);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.conf.a^;", "literalRef247565.js", 942);
     }
     
     @Test
     public void testIssue247565_12() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.po^kus.getSeconds();", "literalRef247565.js", 392);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.po^kus.getSeconds();", "literalRef247565.js", 1014);
     }
     
     @Test
     public void testIssue247565_13() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.d^ob.getFullYear();", "literalRef247565.js", 238);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.d^ob.getFullYear();", "literalRef247565.js", 860);
     }
     
     @Test
     public void testIssue247565_14() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.he^llo();", "literalRef247565.js", 265);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.he^llo();", "literalRef247565.js", 887);
     }
     
     @Test
     public void testIssue247565_15() throws Exception {
-        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.ni^ck;", "literalRef247565.js", 218);
+        checkDeclaration("TestNavigation/public_html/js/issue247565/issue247565.js", "o2_247565.obj.ni^ck;", "literalRef247565.js", 840);
     }
     
     @Test


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists