You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/13 07:08:43 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request #3554: [IoTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
HeimingZ opened a new pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554
When recovering IoTDB, if one storage group is not ready, all read/write requests will be rejected, which is not our respected.
To make each virtual storage group independent, i change the ready unit of recovering IoTDB from the whole db to each independent virtual storage group, so each virtual storage group can resolve read/write requests if it has recovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#issuecomment-878870523
[](https://coveralls.io/builds/41541652)
Coverage decreased (-0.02%) to 68.147% when pulling **9b0a67675cad96fd5bb23c3da49eadf678f0f723 on HeimingZ:IOTDB-1478** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#issuecomment-878870523
[](https://coveralls.io/builds/41493769)
Coverage decreased (-0.04%) to 68.133% when pulling **3aec656f5bbf5e4f64b77a6c419ec071b77aa152 on HeimingZ:IOTDB-1478** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#issuecomment-878870523
[](https://coveralls.io/builds/41318928)
Coverage increased (+0.01%) to 68.185% when pulling **0e1bac21ffe3b90dbc23f979ef4754505367ee47 on HeimingZ:IOTDB-1478** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#issuecomment-878870523
[](https://coveralls.io/builds/41493769)
Coverage decreased (-0.04%) to 68.133% when pulling **3aec656f5bbf5e4f64b77a6c419ec071b77aa152 on HeimingZ:IOTDB-1478** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#issuecomment-878870523
[](https://coveralls.io/builds/41493769)
Coverage decreased (-0.04%) to 68.133% when pulling **3aec656f5bbf5e4f64b77a6c419ec071b77aa152 on HeimingZ:IOTDB-1478** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#issuecomment-878870523
[](https://coveralls.io/builds/41560963)
Coverage decreased (-0.009%) to 68.163% when pulling **73b725b2594680a6ec90be74a48d188ca95db403 on HeimingZ:IOTDB-1478** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #3554: [IOTDB-1478]The whole IoTDB can not read/write if any one sg is not ready
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #3554:
URL: https://github.com/apache/iotdb/pull/3554#discussion_r674443873
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
##########
@@ -493,14 +443,14 @@ public StorageGroupProcessor buildNewStorageGroupProcessor(
}
private void waitAllSgReady(PartialPath storageGroupPath) throws StorageEngineException {
Review comment:
This method could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org