You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/24 06:27:30 UTC

[GitHub] [flink] godfreyhe commented on a change in pull request #14167: [FLINK-19175][table-planner] Tests in JoinITCase do not test Broadcas…

godfreyhe commented on a change in pull request #14167:
URL: https://github.com/apache/flink/pull/14167#discussion_r529227715



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCaseHelper.scala
##########
@@ -34,7 +34,12 @@ object JoinITCaseHelper {
 
   def disableOtherJoinOpForJoin(tEnv: TableEnvironment, expected: JoinType): Unit = {
     val disabledOperators = expected match {
-      case BroadcastHashJoin => "NestedLoopJoin, SortMergeJoin"
+      case BroadcastHashJoin =>
+        // set up the broadcast join threshold to Long.MaxValue
+        // so that the threshold constraints are always met.
+        tEnv.getConfig.getConfiguration.setLong(
+          OptimizerConfigOptions.TABLE_OPTIMIZER_BROADCAST_JOIN_THRESHOLD, Long.MaxValue)

Review comment:
       Thanks for the explanation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org