You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "Feggah (via GitHub)" <gi...@apache.org> on 2023/05/24 17:20:22 UTC
[GitHub] [incubator-devlake] Feggah opened a new issue, #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
Feggah opened a new issue, #5278:
URL: https://github.com/apache/incubator-devlake/issues/5278
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
I created a Project and Blueprint to collect incident data from PagerDuty and deployments from GitHub (5 Services and 5 Repositories). Then I visited the DORA dashboard to see the results.
After that, I created another Project just with one PagerDuty Service (and it was one of the 5 used earlier). When I ran the Pipeline for this new Project, the DORA dashboard represented the new values just for this one.
But when I tried to see again the first Project's DORA dashboard, the incidents dashboards changed.
I saw in the DORA Dashboard Validation that the _raw_pagerduty_incidents table for both Projects had the same number of incidents, which is not true. Probably the 2nd Project Pipeline execution overwrited the values for both Projects?

Or maybe is it an error because I used the same Service in both Projects?
### What do you expect to happen
See independent dashboards based on the selected Project. One Project should not affect in the other
### How to reproduce
- Create a Project collecting incidents data from 5 Services and sync
- See the number of _raw_pagerduty_incidents
- Create another Project with 1 Service, but this one should be one of the 5 selected earlier. Run the sync
- Check again the number of _raw_pagerduty_incidents for both Projects. The value should be the same
### Anything else
_No response_
### Version
v0.17.0-beta6
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed issue #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh closed issue #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
URL: https://github.com/apache/incubator-devlake/issues/5278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Feggah commented on issue #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah commented on issue #5278:
URL: https://github.com/apache/incubator-devlake/issues/5278#issuecomment-1562654339
It is working. I've approved the PR. Thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #5278:
URL: https://github.com/apache/incubator-devlake/issues/5278#issuecomment-1562105682
@Feggah Yes, this is a bug. Good find.
I've made a PR that should fix this: https://github.com/apache/incubator-devlake/pull/5281 Could you please try it out?
About the doc, that table row is outdated and should have a collection mode of incremental, so it makes sense that subsequent runs finish faster. I'll need to update that. The original implementation of PagerDuty was full refresh which is why that is referenced there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Feggah commented on issue #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah commented on issue #5278:
URL: https://github.com/apache/incubator-devlake/issues/5278#issuecomment-1561712997
I can also confirm that any PagerDuty Sync after the first Sync made in DevLake is not going to pull more data from PagerDuty. Instead, it will only override all `board_id` in `board_issues` to change the Service that is related to the Incident. For example:

As you can see, the Service `PZ2SY12` is associated with all PagerDuty incidents. Then I run another Sync in another Project with another Service:

And all `board_id` are overrided:

Then I run another Project Sync again:

And all `board_id` changes:

I think the Projects are impacting in one another when using the PagerDuty plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Feggah commented on issue #5278: [Bug][PagerDuty] All Projects _raw_pagerduty_incidents overidden by one Project's Sync
Posted by "Feggah (via GitHub)" <gi...@apache.org>.
Feggah commented on issue #5278:
URL: https://github.com/apache/incubator-devlake/issues/5278#issuecomment-1561718498
Maybe that's another bug, but it is strange that all PagerDuties Tasks are completed in less than 1 minute when I try to Sync manually the Pipeline.
The Services that I'm trying to collect has more than 2k+ incidents in the last 6 months:

Based on the documentation, the PagerDuty plugin only supports Full Refresh in the Collection Mode, shouldn't it take longer to sync all incidents with that amount of data?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org