You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/03/09 22:45:59 UTC
Review Request 66015: Built CSI spec proto files with cmake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Bugs: MESOS-8657
https://issues.apache.org/jira/browse/MESOS-8657
Repository: mesos
Description
-------
Built CSI spec proto files with cmake.
Diffs
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
Diff: https://reviews.apache.org/r/66015/diff/1/
Testing
-------
`make check` with cmake.
Thanks,
Chun-Hung Hsiao
Re: Review Request 66015: Built CSI spec proto files with cmake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/#review199207
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On March 13, 2018, 7:57 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66015/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 7:57 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8657
> https://issues.apache.org/jira/browse/MESOS-8657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built CSI spec proto files with cmake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
> 3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
> src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
>
>
> Diff: https://reviews.apache.org/r/66015/diff/2/
>
>
> Testing
> -------
>
> `make check` with cmake.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66015: Built CSI spec proto files with CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/#review199233
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On March 14, 2018, 5:29 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66015/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 5:29 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8657
> https://issues.apache.org/jira/browse/MESOS-8657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built CSI spec proto files with CMake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
> 3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
> src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
>
>
> Diff: https://reviews.apache.org/r/66015/diff/3/
>
>
> Testing
> -------
>
> `make check` with CMake.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66015: Built CSI spec proto files with CMake.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/
-----------------------------------------------------------
(Updated March 15, 2018, 12:29 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Fixed the commit message and added `csi.proto` as a byproduct.
Summary (updated)
-----------------
Built CSI spec proto files with CMake.
Bugs: MESOS-8657
https://issues.apache.org/jira/browse/MESOS-8657
Repository: mesos
Description (updated)
-------
Built CSI spec proto files with CMake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
Diff: https://reviews.apache.org/r/66015/diff/3/
Changes: https://reviews.apache.org/r/66015/diff/2-3/
Testing (updated)
-------
`make check` with CMake.
Thanks,
Chun-Hung Hsiao
Re: Review Request 66015: Built CSI spec proto files with cmake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/#review199225
-----------------------------------------------------------
Ship it!
Nit on the commit message: `s/cmake/CMake/g`
- Andrew Schwartzmeyer
On March 13, 2018, 7:57 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66015/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 7:57 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8657
> https://issues.apache.org/jira/browse/MESOS-8657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built CSI spec proto files with cmake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
> 3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
> src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
>
>
> Diff: https://reviews.apache.org/r/66015/diff/2/
>
>
> Testing
> -------
>
> `make check` with cmake.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66015: Built CSI spec proto files with cmake.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/
-----------------------------------------------------------
(Updated March 14, 2018, 2:57 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Andy's comments.
Bugs: MESOS-8657
https://issues.apache.org/jira/browse/MESOS-8657
Repository: mesos
Description
-------
Built CSI spec proto files with cmake.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
Diff: https://reviews.apache.org/r/66015/diff/2/
Changes: https://reviews.apache.org/r/66015/diff/1-2/
Testing
-------
`make check` with cmake.
Thanks,
Chun-Hung Hsiao
Re: Review Request 66015: Built CSI spec proto files with cmake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66015/#review199106
-----------------------------------------------------------
3rdparty/CMakeLists.txt
Lines 260 (patched)
<https://reviews.apache.org/r/66015/#comment279396>
Nit: a few more `###` :)
src/CMakeLists.txt
Lines 31-32 (patched)
<https://reviews.apache.org/r/66015/#comment279399>
But also the prior directories too; hence why I think these two functions may be combined with a `SPEC` option or something to `PROTOC_GENERATE`.
- Andrew Schwartzmeyer
On March 9, 2018, 2:45 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66015/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 2:45 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8657
> https://issues.apache.org/jira/browse/MESOS-8657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Built CSI spec proto files with cmake.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
> 3rdparty/cmake/Versions.cmake 94b0d8048412e00e2480f45e7ce4e6494da4bd5d
> src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
>
>
> Diff: https://reviews.apache.org/r/66015/diff/1/
>
>
> Testing
> -------
>
> `make check` with cmake.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>