You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/05 17:53:28 UTC

[GitHub] [hbase] busbey commented on a change in pull request #1858: HBASE-24506 async client deadlock

busbey commented on a change in pull request #1858:
URL: https://github.com/apache/hbase/pull/1858#discussion_r436074273



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -146,45 +163,43 @@ private void established(Channel ch) throws IOException {
   private boolean reloginInProgress;
 
   private void scheduleRelogin(Throwable error) {
+    assert eventLoop.inEventLoop();

Review comment:
       just checking you want these to be java asserts? production jdks are almost never run with asserts enabled




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org