[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10226: IGNITE-15322 WIP

["anton-vinogradov (via GitHub)" <gi...@apache.org>]

anton-vinogradov commented on code in PR #10226:
URL: https://github.com/apache/ignite/pull/10226#discussion_r1093398466


##########
modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java:
##########
@@ -201,16 +204,29 @@ public void setKernalContext(GridKernalContext ctx) {
     }
 
     /**
-     * @return {@link IgniteCompute} for this cluster group.
+     * @return Internal {@link IgniteCompute} facade for this cluster group.
+     */
+    public final IgniteCompute internalComputeFacade() {

Review Comment:
   "facade" postfix looks suspicious



##########
modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java:
##########
@@ -75,8 +75,11 @@ public class ClusterGroupAdapter implements ClusterGroupEx, Externalizable {
     /** Kernal context. */
     protected transient GridKernalContext ctx;
 
-    /** Compute. */
-    private transient IgniteComputeImpl compute;
+    /** Internal compute facade. */
+    private transient IgniteCompute internalComputeFacade;
+
+    /** Public compute facade. */
+    private transient IgniteCompute publicComputeFacade;

Review Comment:
   "facade" postfix looks suspicious



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org