You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/10 13:07:52 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #210: Add a Closer to manage the closing phase
hanahmily opened a new pull request, #210:
URL: https://github.com/apache/skywalking-banyandb/pull/210
Fixes https://github.com/apache/skywalking/issues/9935
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #210: Add a Closer to manage the closing phase
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #210:
URL: https://github.com/apache/skywalking-banyandb/pull/210#issuecomment-1310265019
# [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#210](https://codecov.io/gh/apache/skywalking-banyandb/pull/210?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2e6cdf) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/3f07c212797aab7e1eee107c76b7777fb2de4b92?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f07c21) will **decrease** coverage by `0.11%`.
> The diff coverage is `61.44%`.
```diff
@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 44.84% 44.73% -0.12%
==========================================
Files 84 84
Lines 8500 8490 -10
==========================================
- Hits 3812 3798 -14
- Misses 4354 4356 +2
- Partials 334 336 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-banyandb/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [banyand/tsdb/bucket/bucket.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2J1Y2tldC9idWNrZXQuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/index/inverted/inverted.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZGV4L2ludmVydGVkL2ludmVydGVkLmdv) | `75.00% <ø> (+0.75%)` | :arrow_up: |
| [pkg/index/lsm/lsm.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZGV4L2xzbS9sc20uZ28=) | `70.37% <ø> (+4.85%)` | :arrow_up: |
| [banyand/tsdb/bucket/strategy.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2J1Y2tldC9zdHJhdGVneS5nbw==) | `65.95% <42.85%> (-7.80%)` | :arrow_down: |
| [banyand/tsdb/segment.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL3NlZ21lbnQuZ28=) | `68.02% <68.42%> (+0.30%)` | :arrow_up: |
| [banyand/tsdb/block.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2Jsb2NrLmdv) | `60.84% <100.00%> (-2.87%)` | :arrow_down: |
| [banyand/tsdb/bucket/queue.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL2J1Y2tldC9xdWV1ZS5nbw==) | `49.72% <100.00%> (+0.28%)` | :arrow_up: |
| [banyand/tsdb/metric.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL21ldHJpYy5nbw==) | `36.23% <100.00%> (+0.93%)` | :arrow_up: |
| [banyand/tsdb/retention.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL3JldGVudGlvbi5nbw==) | `79.54% <100.00%> (+7.32%)` | :arrow_up: |
| [banyand/tsdb/shard.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC90c2RiL3NoYXJkLmdv) | `72.84% <100.00%> (+0.36%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/skywalking-banyandb/pull/210/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] wu-sheng merged pull request #210: Add a Closer to manage the closing phase
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #210:
URL: https://github.com/apache/skywalking-banyandb/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org