[GitHub] [solr] gerlowskija commented on a diff in pull request #1357: SOLR-16540 Fix errors importing main and branch_9x into eclipse

["gerlowskija (via GitHub)" <gi...@apache.org>]

gerlowskija commented on code in PR #1357:
URL: https://github.com/apache/solr/pull/1357#discussion_r1116125296


##########
solr/core/src/test/org/apache/solr/handler/admin/api/package-info.java:
##########
@@ -1,19 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   [Q] What do these package-info files have to do with importing into Eclipse? Do they cause problems in some way?



##########
solr/CHANGES.txt:
##########
@@ -34,6 +34,8 @@ Other Changes
   Previously, the modules would come transitively.
   (David Smiley)
 
+* SOLR-16540: Fix errors importing main and branch_9x into eclipse (Alex Deparvu)

Review Comment:
   I think we usually reserve CHANGES.txt for things a user might care about on upgrading.  Internal refactors, doc changes, or dev-experience improvements don't usually get mentioned I don't think. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org