You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/08/24 22:36:07 UTC

[GitHub] [trafficserver] duke8253 opened a new pull request, #8791: MiMalloc nodump allocator

duke8253 opened a new pull request, #8791:
URL: https://github.com/apache/trafficserver/pull/8791

   When building with MiMalloc, create a no dump heap for each thread, which should behave just like the custom no dump arena for jemalloc. Also updated the license of the file since this is now very different from what facebook had (which this was based on when it all started).
   
   It would be great if @bryancall can run some benchmarks like the ones did for #7501.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1226531839

   ![image](https://user-images.githubusercontent.com/216749/186535600-2c838a0c-13ee-46d8-8b26-5df7f756a90d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1226533391

   Here is a link to the spreadsheet: https://docs.google.com/spreadsheets/d/1oyblceruVgDD9-YhKNfRSEP7Vv5ECN9Rj5O-MlZhYIY/edit?usp=sharing
   Here are the details of the benchmark runs: https://github.com/bryancall/benchmark/tree/main/mimalloc_reports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] github-actions[bot] closed pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8791: MiMalloc nodump allocator
URL: https://github.com/apache/trafficserver/pull/8791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] github-actions[bot] commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1193480493

   This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] duke8253 merged pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
duke8253 merged PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1230740019

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1101850769

   @cmcfarlen will review this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bryancall commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
bryancall commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1226536253

   Overall there was a 2.17% reduction in performance with this PR.  Some of that could be noise in the benchmark run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] duke8253 commented on pull request #8791: MiMalloc nodump allocator

Posted by GitBox <gi...@apache.org>.
duke8253 commented on PR #8791:
URL: https://github.com/apache/trafficserver/pull/8791#issuecomment-1230731159

   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org