You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/13 03:31:09 UTC
[GitHub] [apisix] tokers opened a new pull request #2734: doc: mentioned the gRPC gateway
tokers opened a new pull request #2734:
URL: https://github.com/apache/apisix/pull/2734
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
etcd v3 only supports gRPC as the messaing protocol, only enabling gRPC gateway, APISIX can communicate to it with Restful APIs.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2734: doc: mentioned the gRPC gateway
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#discussion_r522592147
##########
File path: doc/install-dependencies.md
##########
@@ -28,7 +28,7 @@
Note
====
-- Since v2.0 Apache APISIX would not support the v2 protocol storage to etcd anymore, and the minimum etcd version supported is v3.4.0.
+- Since v2.0 Apache APISIX would not support the v2 protocol storage to etcd anymore, and the minimum etcd version supported is v3.4.0. What's more, etcd v3 uses gRPC as the messaging protocol, while Apache APISIX uses HTTP(s) to communicate with etcd cluster, so be sure the [etcd gRPC gateway](https://etcd.io/docs/v3.4.0/dev-guide/api_grpc_gateway/) is enabled.
Review comment:
`HTTP(s)`, `s` should be uppercase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #2734: doc: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#discussion_r522592545
##########
File path: doc/install-dependencies.md
##########
@@ -28,7 +28,7 @@
Note
====
-- Since v2.0 Apache APISIX would not support the v2 protocol storage to etcd anymore, and the minimum etcd version supported is v3.4.0.
+- Since v2.0 Apache APISIX would not support the v2 protocol storage to etcd anymore, and the minimum etcd version supported is v3.4.0. What's more, etcd v3 uses gRPC as the messaging protocol, while Apache APISIX uses HTTP(s) to communicate with etcd cluster, so be sure the [etcd gRPC gateway](https://etcd.io/docs/v3.4.0/dev-guide/api_grpc_gateway/) is enabled.
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #2734: doc: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#issuecomment-726544088
@nic-chen @juzhiyuan Updated the Chinese doc also, please check it out :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2734: doc: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#issuecomment-726545632
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #2734: docs: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#discussion_r522708371
##########
File path: doc/zh-cn/install-dependencies.md
##########
@@ -27,7 +27,7 @@
注意
====
-- Apache APISIX 从 v2.0 开始不再支持 `v2` 版本的 etcd，并且 etcd 最低支持版本为 v3.4.0。
+- Apache APISIX 从 v2.0 开始不再支持 `v2` 版本的 etcd，并且 etcd 最低支持版本为 v3.4.0。更要重要的是，因为 etcd v3 使用 gPRC 作为消息传递协议，而 Apache APISIX 使用 HTTP(S) 与 etcd 集群交互，因此请确保 [etcd gRPC gateway](https://etcd.io/docs/v3.4.0/dev-guide/api_grpc_gateway/) 功能是被启用的。
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2734: doc: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#discussion_r522699713
##########
File path: doc/zh-cn/install-dependencies.md
##########
@@ -27,7 +27,7 @@
注意
====
-- Apache APISIX 从 v2.0 开始不再支持 `v2` 版本的 etcd，并且 etcd 最低支持版本为 v3.4.0。
+- Apache APISIX 从 v2.0 开始不再支持 `v2` 版本的 etcd，并且 etcd 最低支持版本为 v3.4.0。更要重要的是，因为 etcd v3 使用 gPRC 作为消息传递协议，而 Apache APISIX 使用 HTTP(S) 与 etcd 集群交互，因此请确保 [etcd gRPC gateway](https://etcd.io/docs/v3.4.0/dev-guide/api_grpc_gateway/) 功能是被启用的。
Review comment:
1. 因此请使用 etcd 3.4.0+。
2. Typo: 更重要的是
3. Use 通信 instead of 交互
4. 请确保启用 xxx。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2734: docs: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2734:
URL: https://github.com/apache/apisix/pull/2734
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers edited a comment on pull request #2734: doc: mentioned the etcd gRPC gateway
Posted by GitBox <gi...@apache.org>.
tokers edited a comment on pull request #2734:
URL: https://github.com/apache/apisix/pull/2734#issuecomment-726544088
@nic-chen @juzhiyuan Updated the Chinese doc also, please check it out :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org