[jira] [Commented] (FLUME-2689) reloading conf file leads syslogTcpSource not receives any event

["Mike Percy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389082#comment-15389082 ] 

Mike Percy commented on FLUME-2689:
-----------------------------------

Hi [~wy96f], thank you for the patch. It sounds like you have found and fixed an important issue, but there is no new or modified unit test. Do you think you could add a unit test for this fix? Please let me know if you need any help with that.

> reloading conf file leads syslogTcpSource not receives any event
> ----------------------------------------------------------------
>
>                 Key: FLUME-2689
>                 URL: https://issues.apache.org/jira/browse/FLUME-2689
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.5.1
>         Environment: configuring syslog sending logs to remote flume agent
>            Reporter: yangwei
>             Fix For: v1.7.0
>
>         Attachments: flume-2689-1.patch
>
>
> Reloading conf file will stop old syslog source and start new syslog source. Stopping syslog tcp source only closes the NioServerSocketChannel, resulting in the client sends data through the old channel. In that case, the new source never receives data. The tcpdump shows the events have received but the new source doesn't and ss shows the client connection stays same with old one.
> The right way to stop syslog source is close both the NioSocketChannel and NioServerSocketChannel, and shutdown the executor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)