You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2026/08/27 15:23:14 UTC
[PR] [v3-3-test] Fix N+1 query in bulk update for Variables and Pools (#71918) [airflow]
github-actions[bot] opened a new pull request, #72160:
URL: https://github.com/apache/airflow/pull/72160
BulkVariableService.handle_bulk_update and BulkPoolService.handle_bulk_update
each ran one batched existence-check query up front, then discarded the
result and re-queried every entity individually inside the loop. The
sibling handle_bulk_delete methods in the same two files, and
connections.py's handle_bulk_update, already reuse the batched-lookup
dict correctly -- this was the one spot left over from the earlier
bulk-delete N+1 fixes.
update_orm_from_pydantic in both files now takes the already-fetched
ORM object instead of a key/name string, matching the design
connections.py already uses, so the update loop no longer needs its
own per-item query.
(cherry picked from commit 562e7307c2cffa1af1dc74813a215221d4c7ad9b)
Co-authored-by: Jyun-An Chen <ju...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-3-test] Fix N+1 query in bulk update for Variables and Pools (#71918) [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #72160:
URL: https://github.com/apache/airflow/pull/72160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-3-test] Fix N+1 query in bulk update for Variables and Pools (#71918) [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #72160:
URL: https://github.com/apache/airflow/pull/72160#issuecomment-5450324611
Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to **[Airflow 3.3.2](https://github.com/apache/airflow/milestone/150)** based on: bug fix merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.
> This comment was generated by [Milestone Tag Assistant](https://github.com/apache/airflow/blob/main/.github/workflows/milestone-tag-assistant.yml).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [v3-3-test] Fix N+1 query in bulk update for Variables and Pools (#71918) [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #72160:
URL: https://github.com/apache/airflow/pull/72160#issuecomment-5450312060
Unrelated CI failure, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org