You are viewing a plain text version of this content. The canonical link for it is here.

Posted to devnull@infra.apache.org by "taliesinb (GitHub)" <gi...@apache.org> on 2018/08/23 22:34:29 UTC

[GitHub] [incubator-mxnet] taliesinb opened issue #12320: Clojure's approx= test function has a weakness

## Description
The clojure framework's `approx=` test utility function (defined in `contrib/clojure-package/test/org/apache/clojure_mxnet/util_test.clj`) is unable to detect differences between arrays if they are of different sizes and the difference occurs in the excess.

For example, this returns true, but should return false:

```
(approx= 1e-9 [1 1 1] [1 1 1 9 9 9])
```

This means that tests that use `approx=` in the clojure test suite can incorrectly succeed.

[ Full content available at: https://github.com/apache/incubator-mxnet/issues/12320 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-mxnet] ankkhedia commented on issue #12320: Clojure's approx= test function has a weakness

Posted by "ankkhedia (GitHub)" <gi...@apache.org>.

@mxnet-label-bot [Clojure]

[ Full content available at: https://github.com/apache/incubator-mxnet/issues/12320 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-mxnet] taliesinb commented on issue #12320: Clojure's approx= test function has a weakness

Posted by "taliesinb (GitHub)" <gi...@apache.org>.

I have fixed this in https://github.com/apache/incubator-mxnet/pull/12064.

[ Full content available at: https://github.com/apache/incubator-mxnet/issues/12320 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-mxnet] gigasquid commented on issue #12320: Clojure's approx= test function has a weakness

Posted by "gigasquid (GitHub)" <gi...@apache.org>.

Thanks @taliesinb 😸  - Closing this issue

[ Full content available at: https://github.com/apache/incubator-mxnet/issues/12320 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-mxnet] gigasquid closed issue #12320: Clojure's approx= test function has a weakness

Posted by "gigasquid (GitHub)" <gi...@apache.org>.

[ issue closed by gigasquid ]

[ Full content available at: https://github.com/apache/incubator-mxnet/issues/12320 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org