You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Wojciech Meler (JIRA)" <ji...@apache.org> on 2011/07/30 05:44:09 UTC

[jira] [Created] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

nodetool netstats progress does not update on receiving side
------------------------------------------------------------

                 Key: CASSANDRA-2972
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.8.1
            Reporter: Wojciech Meler


when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-2972.
---------------------------------------

    Resolution: Fixed
      Reviewer: jbellis

committed v2

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 0.8.4
>
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2972:
--------------------------------------

    Fix Version/s: 0.8.4

I think we also need to update remoteFile.progress in IncomingStreamReader, at least in the 0.8 branch

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 0.8.4
>
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuki Morishita updated CASSANDRA-2972:
--------------------------------------

    Attachment: cassandra-0.8-2972-v2.txt

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073626#comment-13073626 ] 

Yuki Morishita commented on CASSANDRA-2972:
-------------------------------------------

Slightly modified version.

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079028#comment-13079028 ] 

Jonathan Ellis commented on CASSANDRA-2972:
-------------------------------------------

ah, you're right.  i was thrown off by the whacky indentation there for ISR.

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 0.8.4
>
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yuki Morishita updated CASSANDRA-2972:
--------------------------------------

    Attachment: cassandra-0.8-2972.txt

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>         Attachments: cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079075#comment-13079075 ] 

Hudson commented on CASSANDRA-2972:
-----------------------------------

Integrated in Cassandra-0.8 #254 (See [https://builds.apache.org/job/Cassandra-0.8/254/])
    include files-to-be-streamed in StreamInSession.getSources
patch by Yuki Morishita; reviewed by jbellis for CASSANDRA-2972

jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1153668
Files : 
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/streaming/StreamInSession.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/streaming/IncomingStreamReader.java


> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 0.8.4
>
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2972:
--------------------------------------

    Priority: Minor  (was: Major)
    Assignee: Yuki Morishita

What do you think, Yuki?

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079025#comment-13079025 ] 

Yuki Morishita commented on CASSANDRA-2972:
-------------------------------------------

IncomingStreamReader#readnwrite (or SSLIncomingStreamReader#readwrite) in the 0.8 branch does update remoteFile.progress, so the issue is just a matter of dispaying through JMX.

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 0.8.4
>
>         Attachments: cassandra-0.8-2972-v2.txt, cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2972) nodetool netstats progress does not update on receiving side

Posted by "Yuki Morishita (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073618#comment-13073618 ] 

Yuki Morishita commented on CASSANDRA-2972:
-------------------------------------------

Patch attached for 0.8 branch.
StreamInSession holds references to all pending files(files attribute) and current processing file(current attribute). The former include the latter but those are different objects after deserialized, and only the latter gets update on progress.
When returning incoming streaming status via JMX, only the former pending files described above are returned due to the nature of HashSet#add.

> nodetool netstats progress does not update on receiving side
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-2972
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2972
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.1
>            Reporter: Wojciech Meler
>            Assignee: Yuki Morishita
>            Priority: Minor
>         Attachments: cassandra-0.8-2972.txt
>
>
> when you add/remove node to cluster, nodetool netstats show correct results only on sending side - on receiving side you can see only 0% progress

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira