[GitHub] [superset] rusackas commented on a change in pull request #12318: fix: south pane scrolling issues

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #12318:
URL: https://github.com/apache/superset/pull/12318#discussion_r553119965



##########
File path: superset-frontend/src/SqlLab/components/SouthPane.jsx
##########
@@ -59,6 +60,29 @@ const defaultProps = {
   offline: false,
 };
 
+const StyledPane = styled.div`
+  width: 100%;
+
+  .ant-tabs .ant-tabs-content-holder {
+    overflow: visible;
+  }
+
+  .SouthPaneTabs {
+    height: 100%;
+    display: flex;
+    flex-direction: column;
+  }
+  .tab-content {
+    .alert {
+      margin-top: 10px;

Review comment:
       ```suggestion
         margin-top: ${({ theme }) => theme.gridUnit * 2}px;
   ```
   It's ideal to move hard-coded pixel gutters/margins/paddings/spacings like this to using the `gridUnit` from the Superset theme. In cases like this where it's been 10px for a long time, we should use our best judgment as to whether 2 units (8px) or 3 units (12px) looks more consistent. 8px is more common, so I took a guess here :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org