You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/01/03 19:40:54 UTC
[kudu-CR] [rpc] update ServiceIf::service name() signature
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16916
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
[rpc] update ServiceIf::service_name() signature
This patch changes the signature of the ServiceIf::service_name() method
to return 'const std::string&' instead of 'std::string' and updates a few
related call sites accordingly. In addition, this patch removes unused
ServiceIf::methods_by_name() accessor method.
The ServiceIf::service_name() method isn't in any hot path but it's used
in ServicePool::RejectTooBusy(). The latter is usually called under
high memory pressure when it's preferred to avoid memory allocations
at least because of the lock contention in the tcmalloc library.
I also did a few formatting changes in protoc-gen-krpc.cc to improve
the readability of the auto-generated code since I looked at that code
recently.
Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
---
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/server/rpc_server.cc
7 files changed, 269 insertions(+), 262 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/16916/1
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Thanks for the update!
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@59
PS3, Line 59: using kudu::rpc_test::AddRequestPB;
> I'm not going to address this: this is test-only code and this header is us
Ack
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 05 Jan 2021 18:46:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h
File src/kudu/rpc/service_if.h:
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h@118
PS3, Line 118: explicit GeneratedServiceIf(const scoped_refptr<ResultTracker>& tracker);
Not quite sure I understand the reasoning/context behind adding this, everything else in the patch lgtm.
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 05 Jan 2021 02:00:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Patch Set 3: Verified+1
unrelated test failure:
src/kudu/integration-tests/disk_failure-itest.cc:289: Failure
Expected: num_failed
Which is: 10
To be equal to: failed_on_ts
Which is: 9
src/kudu/util/test_util.cc:336: Failure
Failed
Timed out waiting for assertion to pass.
src/kudu/integration-tests/disk_failure-itest.cc:330: Failure
Expected: WaitForFailedTablets(error_ts, kNumTablets) doesn't generate new fatal failures in the current thread.
Actual: it does.
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 04 Jan 2021 20:39:10 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16916
to look at the new patch set (#3).
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
[rpc] update ServiceIf::service_name() signature
This patch changes the signature of the ServiceIf::service_name() method
to return 'const std::string&' instead of 'std::string' and updates a few
related call sites accordingly. In addition, this patch removes unused
ServiceIf::methods_by_name() accessor method and makes
ServiceIf::ParseParam() and ServiceIf::RespondBadMethod() methods
static.
The ServiceIf::service_name() method isn't in any hot path but it's used
in ServicePool::RejectTooBusy(). The latter is usually called under
high memory pressure when it's preferred to avoid memory allocations
at least because of the lock contention in the tcmalloc library.
I also did a few formatting changes in protoc-gen-krpc.cc to improve
the readability of the auto-generated code since I looked at that code
recently.
Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
---
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/server/rpc_server.cc
7 files changed, 278 insertions(+), 271 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/16916/3
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h
File src/kudu/rpc/service_if.h:
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h@118
PS3, Line 118: explicit GeneratedServiceIf(const scoped_refptr<ResultTracker>& tracker);
> Ah, that's to use initializer-list style syntax in the constructor of the a
I see, thanks for letting me know.
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 05 Jan 2021 03:13:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Patch Set 3:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@59
PS3, Line 59: using kudu::rpc_test::AddRequestPB;
> warning: using declarations in the global namespace in headers are prohibit
I'm not going to address this: this is test-only code and this header is used only in a few places. Updating this code is out of the scope of the patch.
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@60
PS3, Line 60: using kudu::rpc_test::AddResponsePB;
> warning: using declarations in the global namespace in headers are prohibit
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@61
PS3, Line 61: using kudu::rpc_test::CalculatorError;
> warning: using declarations in the global namespace in headers are prohibit
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@83
PS3, Line 83: using kudu::rpc_test_diff_package::ReqDiffPackagePB;
> warning: using declarations in the global namespace in headers are prohibit
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@84
PS3, Line 84: using kudu::rpc_test_diff_package::RespDiffPackagePB;
> warning: using declarations in the global namespace in headers are prohibit
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@134
PS3, Line 134: void DoAdd(InboundCall *incoming) {
> warning: method 'DoAdd' can be made static [readability-convert-member-func
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@402
PS3, Line 402: const std::string GenericCalculatorService::kFullServiceName = "kudu.rpc.GenericCalculatorService";
> warning: variable 'kFullServiceName' defined in a header file; variable def
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@403
PS3, Line 403: const char *GenericCalculatorService::kAddMethodName = "Add";
> warning: variable 'kAddMethodName' defined in a header file; variable defin
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@404
PS3, Line 404: const char *GenericCalculatorService::kSleepMethodName = "Sleep";
> warning: variable 'kSleepMethodName' defined in a header file; variable def
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/rpc-test-base.h@405
PS3, Line 405: const char *GenericCalculatorService::kSleepWithSidecarMethodName = "SleepWithSidecar";
> warning: variable 'kSleepWithSidecarMethodName' defined in a header file; v
ditto
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.cc
File src/kudu/rpc/service_if.cc:
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.cc@149
PS3, Line 149: GeneratedServiceIf::GeneratedServiceIf(const scoped_refptr<ResultTracker>& tracker)
> warning: pass by value and use std::move [modernize-pass-by-value]
I'm not going to address this TidyBot comment since the signatures of the rest of involved methods do not pass this by value.
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Mon, 04 Jan 2021 17:14:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Tidy Bot, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16916
to look at the new patch set (#2).
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
[rpc] update ServiceIf::service_name() signature
This patch changes the signature of the ServiceIf::service_name() method
to return 'const std::string&' instead of 'std::string' and updates a few
related call sites accordingly. In addition, this patch removes unused
ServiceIf::methods_by_name() accessor method.
The ServiceIf::service_name() method isn't in any hot path but it's used
in ServicePool::RejectTooBusy(). The latter is usually called under
high memory pressure when it's preferred to avoid memory allocations
at least because of the lock contention in the tcmalloc library.
I also did a few formatting changes in protoc-gen-krpc.cc to improve
the readability of the auto-generated code since I looked at that code
recently.
Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
---
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/server/rpc_server.cc
7 files changed, 275 insertions(+), 268 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/16916/2
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
[rpc] update ServiceIf::service_name() signature
This patch changes the signature of the ServiceIf::service_name() method
to return 'const std::string&' instead of 'std::string' and updates a few
related call sites accordingly. In addition, this patch removes unused
ServiceIf::methods_by_name() accessor method and makes
ServiceIf::ParseParam() and ServiceIf::RespondBadMethod() methods
static.
The ServiceIf::service_name() method isn't in any hot path but it's used
in ServicePool::RejectTooBusy(). The latter is usually called under
high memory pressure when it's preferred to avoid memory allocations
at least because of the lock contention in the tcmalloc library.
I also did a few formatting changes in protoc-gen-krpc.cc to improve
the readability of the auto-generated code since I looked at that code
recently.
Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Reviewed-on: http://gerrit.cloudera.org:8080/16916
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/service_if.cc
M src/kudu/rpc/service_if.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/server/rpc_server.cc
7 files changed, 278 insertions(+), 271 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [rpc] update ServiceIf::service name() signature
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16916 )
Change subject: [rpc] update ServiceIf::service_name() signature
......................................................................
Patch Set 3:
(1 comment)
Thank you for the review!
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h
File src/kudu/rpc/service_if.h:
http://gerrit.cloudera.org:8080/#/c/16916/3/src/kudu/rpc/service_if.h@118
PS3, Line 118: explicit GeneratedServiceIf(const scoped_refptr<ResultTracker>& tracker);
> Not quite sure I understand the reasoning/context behind adding this, every
Ah, that's to use initializer-list style syntax in the constructor of the auto-generated service skeleton class in https://gerrit.cloudera.org/#/c/16916/3/src/kudu/rpc/protoc-gen-krpc.cc@486
Prior to this, it was necessary to have an assignment in the constructor of the service skeleton class after the field was already initialized in the constructor of the base (i.e. GeneratedServiceIf) class.
--
To view, visit http://gerrit.cloudera.org:8080/16916
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7fc425cf789fa31e99642061b6474b0effd489
Gerrit-Change-Number: 16916
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 05 Jan 2021 02:44:50 +0000
Gerrit-HasComments: Yes